Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML token sent within JSON are not detected #31

Open
jcmoreno opened this issue Dec 3, 2018 · 1 comment
Open

SAML token sent within JSON are not detected #31

jcmoreno opened this issue Dec 3, 2018 · 1 comment

Comments

@jcmoreno
Copy link

jcmoreno commented Dec 3, 2018

Hi,

Can SAML requests embedded within JSON be detected?

I could also take a stab at it but where should I begin?

Excellent tool BTW.

Thank you

@emanuelduss
Copy link
Member

emanuelduss commented Dec 4, 2018

Hi jcmoreno

Thanks for the positive feedback!

Sadly, no.

SAML Raider currently can only detect SAML Messages if they are inside a GET parameter called SAMLRequest or SAMLResponse or in the POST body.

There is already another issue (#30) that addresses that SAML Messages are not detected within non-default parameter names (like the two mentioned above).

There is another related issue: #8. So it seems that there is sometimes a SAML message just somewhere around.

If you want to look into it, you should have a look at the class that detects the SAML Message, and rebuilds it after a modification. This is the class SamlTabController (src/main/java/application/SamlTabController.java). If you ask me now, the class looks a bit messy and it's probbably not so easy to add JSON support. But generally speaking, it should be possible.

At the moment, the code looks a bit messy and very static and a complete rewrite of the SAML Message detection should be done.

Question to you: Have you encountered a SAML message like this before? How yould you detect it inside the JSON payload? Does it have a key name or is it just some url/base64 encoded string somewhere inside the JSON?

Thanks and best regards,
Emanuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants