Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port sequencing error models from BEAST1 to BEAST2 #173

Open
alexeid opened this issue Jul 30, 2014 · 13 comments
Open

Port sequencing error models from BEAST1 to BEAST2 #173

alexeid opened this issue Jul 30, 2014 · 13 comments

Comments

@alexeid
Copy link
Member

alexeid commented Jul 30, 2014

Sequencing error models (and post-mortem damage models) are implemented in BEAST1. See http://mbe.oxfordjournals.org/content/26/2/245.full
Users would like this ported to BEAST2.

@ddkapan
Copy link

ddkapan commented Oct 20, 2021

Any update on generalized DNA damage handling a la http://mbe.oxfordjournals.org/content/26/2/245.full?

@kche309
Copy link
Collaborator

kche309 commented Oct 21, 2021

@ddkapan I have been working on an error model framework for beast2 which includes a nucleotide sequencing error model (in testing phase). It is slightly different from the Oxford paper in that we did not use an exponential.

www.github.com/bioDS/beast-phylonco

I can add the exact model from the Oxford paper. This should take about a day, thorough testing may take 1-2 weeks.

Please wait for the new release v0.0.5 which will include new models, faster implementation and bug fixes.

I'll update you as things progress :)

@ddkapan
Copy link

ddkapan commented Oct 22, 2021 via email

@ddkapan
Copy link

ddkapan commented Jan 21, 2022

Hi, @kche309 any update on adding the PMD damage model and in general when the new release v0.0.5 will come out? Although I'm not sure I have the proficiency to help code the model, I'd love to help with the test of the update. Thanks! Durrell

@kche309
Copy link
Collaborator

kche309 commented Jan 22, 2022

Hi @ddkapan, We're currently working on getting the user interface working (Beauti). There's currently a bug in the templates which means configuring these types of analyses will require manual editing of xml files (bioDS/beast-phylonco#8).

We will be adding the PMD model as soon as the UI issue is resolved.

@ddkapan
Copy link

ddkapan commented Feb 7, 2022

Hi @kche309 that's awesome. Once you have the UI issue resolved and time to add in the PMD model, I'll be happy to try out the code and report back. I really appreciate your efforts!

@kche309
Copy link
Collaborator

kche309 commented Mar 1, 2022

Hi @ddkapan just a brief update on expected timeframe for the PMD model. We will schedule to implement this in April. I will let you know once an early version is available.

@ddkapan
Copy link

ddkapan commented Mar 1, 2022 via email

@ddkapan
Copy link

ddkapan commented Jul 7, 2022

Hi sorry to be a pest, any further updates would be appreciated. Happy to test it out as well! :) Durrell

@kche309
Copy link
Collaborator

kche309 commented Jul 14, 2022

@ddkapan Hi work is in progress for this model on branch https://github.com/bioDS/beast-phylonco/tree/PMDErrorModel
The main source code is in PMDErrorModel.java
This is pending a fix on the Gradle build file testing and a few TODOs.

@walterxie thanks for your help on the Gradle fix.

@kche309
Copy link
Collaborator

kche309 commented Jul 15, 2022

@ddkapan I have a few quick questions about your data.
(1) Do you have a mix of extant species and museum fossil samples?
(2) Would it be correct to assume you have a list of taxa names for your fossil data (potentially affected by post-mortem damage)?

@kche309
Copy link
Collaborator

kche309 commented Jul 16, 2022

@ddkapan A brief update, I've added an exclusion option (for excluding certain taxa from the PMD error model, e.g. extant species).

Main code is now complete, I will be adding some unit tests and working on the XML template 😄

@ddkapan
Copy link

ddkapan commented Oct 26, 2022

HI @kche309, I'm sorry I missed your note on my GitHub notifications. Awesome work (!) and yes we will have taxa from museum samples with PMD and modern samples where it is not expected so that's perfect.. I also see the notes atbeast-phylonco. Now I'll need to figure out how to use the tools. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants