Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIThreadTestMethod] doesn't forward [Ignore] for test to cause test to be ignored when running tests... #121

Open
20 tasks
michael-hawker opened this issue Aug 16, 2023 · 0 comments

Comments

@michael-hawker
Copy link
Member

Describe the bug

Found this out when trying to remove a test from our matrix: CommunityToolkit/Windows#174

Apparently, it wasn't actually removed as the [UIThreadTestMethod] doesn't forward the [Ignore] attribute over to the generated test.

Steps to reproduce

1. Take a test with a `[UIThreadTestMethod]` attribute
2. Add `[Ignore]` to method

Expected behavior

Expect generated test to also have [Ignore] on it.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

michael-hawker added a commit to CommunityToolkit/Windows that referenced this issue Aug 16, 2023
… it's just random based on number of tests run...)

Need to comment out as Ignore ignored... see CommunityToolkit/Tooling-Windows-Submodule#121
Related to investigation, see info in actions/runner-images#7937
michael-hawker added a commit to CommunityToolkit/Windows that referenced this issue Aug 16, 2023
… it's just random based on number of tests run...)

Need to comment out as Ignore ignored... see CommunityToolkit/Tooling-Windows-Submodule#121
Related to investigation, see info in actions/runner-images#7937
michael-hawker added a commit to CommunityToolkit/Windows that referenced this issue Aug 17, 2023
… it's just random based on number of tests run...)

Need to comment out as Ignore ignored... see CommunityToolkit/Tooling-Windows-Submodule#121
Related to investigation, see info in actions/runner-images#7937
michael-hawker added a commit to CommunityToolkit/Windows that referenced this issue Aug 17, 2023
… it's just random based on number of tests run...)

Need to comment out as Ignore ignored... see CommunityToolkit/Tooling-Windows-Submodule#121
Related to investigation, see info in actions/runner-images#7937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant