From b8fbeef4de5158ffa077148dda2fe48daadc7da0 Mon Sep 17 00:00:00 2001
From: Remco de Boer <29308176+redeboer@users.noreply.github.com>
Date: Mon, 7 Aug 2023 21:51:51 +0200
Subject: [PATCH] MAINT: remove deprecated linter VSCode settings

---
 .vscode/settings.json                    | 8 --------
 src/repoma/check_dev_files/deprecated.py | 4 ----
 src/repoma/check_dev_files/mypy.py       | 1 -
 src/repoma/check_dev_files/vscode.py     | 8 ++++++++
 4 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index a97d47f6..dda97502 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -43,14 +43,6 @@
   "python.analysis.autoImportCompletions": false,
   "python.analysis.inlayHints.pytestParameters": true,
   "python.analysis.typeCheckingMode": "strict",
-  "python.formatting.provider": "black",
-  "python.linting.banditEnabled": false,
-  "python.linting.enabled": true,
-  "python.linting.flake8Enabled": false,
-  "python.linting.mypyEnabled": false,
-  "python.linting.pydocstyleEnabled": false,
-  "python.linting.pylamaEnabled": false,
-  "python.linting.pylintEnabled": false,
   "python.testing.pytestArgs": ["--color=no", "--no-cov", "-vv"],
   "python.testing.pytestEnabled": true,
   "python.testing.unittestEnabled": false,
diff --git a/src/repoma/check_dev_files/deprecated.py b/src/repoma/check_dev_files/deprecated.py
index d5f78c8b..d73b60eb 100644
--- a/src/repoma/check_dev_files/deprecated.py
+++ b/src/repoma/check_dev_files/deprecated.py
@@ -12,7 +12,6 @@
 from repoma.utilities.vscode import (
     remove_extension_recommendation,
     remove_settings,
-    set_setting,
 )
 
 if TYPE_CHECKING:
@@ -39,7 +38,6 @@ def _remove_flake8() -> None:
     executor(remove_precommit_hook, "flake8")
     executor(remove_precommit_hook, "nbqa-flake8")
     executor(remove_settings, ["flake8.importStrategy"])
-    executor(set_setting, {"python.linting.flake8Enabled": False})
     executor.finalize()
 
 
@@ -91,7 +89,6 @@ def _remove_pydocstyle() -> None:
     )
     executor(__uninstall, "pydocstyle", check_options=["lint", "sty"])
     executor(remove_precommit_hook, "pydocstyle")
-    executor(set_setting, {"python.linting.pydocstyleEnabled": False})
     executor.finalize()
 
 
@@ -103,7 +100,6 @@ def _remove_pylint() -> None:
     executor(remove_precommit_hook, "pylint")
     executor(remove_precommit_hook, "nbqa-pylint")
     executor(remove_settings, ["pylint.importStrategy"])
-    executor(set_setting, {"python.linting.pylintEnabled": False})
     executor.finalize()
 
 
diff --git a/src/repoma/check_dev_files/mypy.py b/src/repoma/check_dev_files/mypy.py
index f4f09670..29aa79bd 100644
--- a/src/repoma/check_dev_files/mypy.py
+++ b/src/repoma/check_dev_files/mypy.py
@@ -39,7 +39,6 @@ def _update_vscode_settings() -> None:
         settings = {
             "mypy-type-checker.args": ["--config-file", "pyproject.toml"],
             "mypy-type-checker.importStrategy": "fromEnvironment",
-            "python.linting.mypyEnabled": False,
         }
         executor(set_setting, settings)
     executor.finalize()
diff --git a/src/repoma/check_dev_files/vscode.py b/src/repoma/check_dev_files/vscode.py
index 5f755b5f..938699ff 100644
--- a/src/repoma/check_dev_files/vscode.py
+++ b/src/repoma/check_dev_files/vscode.py
@@ -42,6 +42,14 @@ def _remove_outdated_settings() -> None:
         "githubPullRequests.telemetry.enabled",
         "gitlens.advanced.telemetry.enabled",
         "python.analysis.diagnosticMode",
+        "python.formatting.provider",
+        "python.linting.banditEnabled",
+        "python.linting.enabled",
+        "python.linting.flake8Enabled",
+        "python.linting.mypyEnabled",
+        "python.linting.pydocstyleEnabled",
+        "python.linting.pylamaEnabled",
+        "python.linting.pylintEnabled",
         "telemetry.telemetryLevel",
     ]
     vscode.remove_settings(outdated_settings)