Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search-page.php page #38

Open
amaneureka opened this issue Sep 3, 2016 · 5 comments
Open

search-page.php page #38

amaneureka opened this issue Sep 3, 2016 · 5 comments
Labels
backend enhancement front end

Comments

@amaneureka
Copy link
Member

amaneureka commented Sep 3, 2016 •
edited
Loading

@kalradivyanshu could you use header.php file for navigation bar?

I hate the UI (search page), Any inputs from @amanmj @mbad0la ?

maybe @prernakakkar95 @JeeveshN could do this?

PS:
Link: http://collegespace.herokuapp.com/search-page.php?query=Results
@amanmj
Copy link
Contributor

amanmj commented Sep 3, 2016

hide that div saying "type a query to search" ... this will be done from the home page only

@amanmj
Copy link
Contributor

amanmj commented Sep 3, 2016

and there is an overflow in between the body and footer.. Please fix that too
image

@kalradivyanshu
Copy link
Contributor

Updated searchPage1 branch, included navbar from header.php, removed "type a ..." div.

@amaneureka
Copy link
Member Author

Could you create a Pull Request for the same?

@JeeveshN
Copy link
Contributor

JeeveshN commented Sep 4, 2016 •
edited
Loading

@amaneureka @kalradivyanshu maybe instead of showing it in a list form we could use the UI we have on the home page for Latest on CollegeSpace Updates with little changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend enhancement front end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amanmj @amaneureka @kalradivyanshu @JeeveshN