Refactor: 프리뷰 사용하는 부분 통합 #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
yumzen
reviewed
Jan 19, 2025
| } | ||
|
|
||
| @Override | ||
| public Optional<Post> findTopByTeamAndPostIdLessThanOrderByCreatedAtDescPostIdDesc(Team findTeam, Long postId) { |
There was a problem hiding this comment.
boolean isGreaterThan 파라미터를 추가적으로 받아서 postId 대소 비교 결과만 다른 두 쿼리를 하나로 합치는 게 어떨까요??
| } | ||
|
|
||
| @Override | ||
| public Optional<Post> findTopByMemberAndPostIdLessThanOrderByCreatedAtDescPostIdDesc(Member member, Long postId) { |
| @@ -318,4 +314,115 @@ private BooleanBuilder searchBy(String authorName, String teamName, String proje | |||
| } | |||
| return new BooleanBuilder(); | |||
| } | |||
|
|
|||
| @Override | |||
| @@ -16,17 +16,26 @@ public class PostResponseDTO { | |||
| @Builder | |||
| @JsonNaming(PropertyNamingStrategies.SnakeCaseStrategy.class) | |||
| @JsonInclude(JsonInclude.Include.NON_NULL) | |||
| public record SimplePostResponseDTO( | |||
| public record PostPreviewDTO( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
프리뷰 사용되는 부분 DTO 통합했습니다
해당 과정에서 발행할 수 있는 영속성 컨텍스트 문제 해결해주었습니다.