Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PR template #347

Open
6 tasks
MadhavBahl opened this issue Oct 5, 2020 · 12 comments
Open
6 tasks

Add a PR template #347

MadhavBahl opened this issue Oct 5, 2020 · 12 comments

Comments

@MadhavBahl
Copy link
Member

Add the following check list in the PR template:

  • Created a folder with the name of language you code inside directory for the day you are making the contribution to
  • Added your Codes
  • Tested your codes
  • Added credits (author and date) at the top of the code
  • Updated README.md of the day you are contributing to
  • Added yourself as a contributor using all-conributors-cli
@SvA1
Copy link
Contributor

SvA1 commented Oct 5, 2020

Hi @MadhavBahlMD. I'd be glad to work on this. Can you assign me to the issue?

@thelavenderhue
Copy link

Hey @MadhavBahlMD can I work on this?

@yashasvimatta
Copy link

Hi @MadhavBahlMD this looks good. Could you assign me the issue?

@Red-0111
Copy link

Red-0111 commented Oct 5, 2020

Please assign @MadhavBahlMD I will try my best

@MadhavBahl
Copy link
Member Author

Hey guys,

Thanks a lot for your enthusiasm to contribute,

You all can feel free to take this issue and raise a PR,

Although I would recommend @SvA1 to take this up since he commented first,

but you all can feel free to discuss ideas here, and also take up lead on more ideas for this repository 🥳

@SvA1
Copy link
Contributor

SvA1 commented Oct 5, 2020

Thanks!

@yashasvimatta
Copy link

Hi @MadhavBahlMD i have created a pull request for fixing the issue , could you review it?

@diogenesdauster
Copy link

I've made one PR for this issue, could you review it ? @MadhavBahlMD

@MadhavBahl
Copy link
Member Author

Hi @yashasvimatta and @diogenesdauster
Thanks a lot for your contributions 🥳
I will have a look at both your PRs on weekend

@rajpratyush
Copy link

@MadhavBahlMD hi i am new to this github. i have made changes to the readme and the uploaded the code in the required directory but i am still having troubling to add my name into the contributors list. i did looked into the contributing guidelines but i am still unable to understand could you please guide me

@thelavenderhue thelavenderhue removed their assignment Oct 22, 2020
@elizabethqiu
Copy link

elizabethqiu commented Oct 25, 2020

Hi @MadhavBahl ! can I work on this?

@NormalVad
Copy link

Hi @MadhavBahl , I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants