Report ccv score/temperature on case report #5173
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5173 +/- ##
==========================================
- Coverage 84.50% 84.46% -0.04%
==========================================
Files 327 327
Lines 19789 19800 +11
==========================================
+ Hits 16722 16725 +3
- Misses 3067 3075 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you @molucorner! As you like with the alignment - the report layout is messy as it is - but if you don't have a specific reason, I would say leave the centering out.
| @@ -674,7 +674,7 @@ <h4>Scout case analysis report</h4> - created on: <strong>{{report_created_ | |||
| {% endif %} | |||
| </tr> | |||
| </thead> | |||
| <tbody> | |||
| <tbody style="text-align:center;"> | |||
There was a problem hiding this comment.
Hm, the alignment in general isn't super consistent on the report, but to me a couple of table lines in the bulk there with suddenly centered numbers stands out a bit, where it would look quite good on its own. If you had good reason, keep it - it seems to align somewhat with some other columns in the same card - but otherwise seems easier to keep them all defaulting left.
There was a problem hiding this comment.
The only reason is that I personally think it looks better, but I don't have a problem changing it back
| @@ -715,7 +715,7 @@ <h4>Scout case analysis report</h4> - created on: <strong>{{report_created_ | |||
| {% endif %} | |||
| <td> | |||
| {% if variant.acmg_classification %} | |||
| <span class="badge rounded-pill bg-{{variant.acmg_classification['color'] if variant.acmg_classification['color'] else 'secondary'}}" title="{{variant.acmg_classification['code']}}">{{variant.acmg_classification['code'] }}</span> | |||
| <span class="badge rounded-pill bg-{{variant.acmg_classification['color'] if variant.acmg_classification['color'] else 'secondary'}}" title="{{variant.acmg_classification['label']}}">{{variant.acmg_classification['label'] }}</span> | |||
|
This PR adds a functionality or fixes a bug.
Closes issue #5143
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stageand the server iscg-vm1.ssh <USER.NAME>@cg-vm1.scilifelab.sesudo -iu hiseq.clinicalssh localhostpodman pssystemctl --user stop scout.targetsystemctl --user start scout@<this_branch>systemctl --user status scout.targetscout-stage) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.seus; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browserbash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>us; scout --versionpaxaprocedure, which will release the allocated resource (scout-stage) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: