-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entry version has disappeared from gene panel lists #5082
Comments
Hi @ielvers! Thank you for being on the lookout! The entry version display was reworked #4957. You can see some of the discussion behind the change here: #4956. Bottom line, is as before only the new genes for the version are clearly marked "NEW" and the ones that were already in the panel are blank instead of showing the previous version. The full history can be seen as before by searching for a particular gene, or clicking through old versions, as before. Loss of inheritance terms is not intended: I can see them fine for other panels, both newer and older. Just double checking, ofcourse you know they were there before for v17? And also v1? It's a little late, and my db connection is acting up, but I can reach the stage server. It has a v17 and a recent v18, both without any manual inheritance models annotated on the genes? |
Not trying to lecture here, just thinking: do you think we could change how we communicate updates somehow? I can somewhat understand that users don't follow all discussions on the repo. But you do read through the change notes in each update email, right? 😊 |
Re: entry version Re: inheritance terms in NBS-M Re: update emails
Again, Scout is a great tool and we very, very much appreciate all the work you all do. Sorry for asking about stuff that has been mentioned in an update email. |
Hi @ielvers, when you created a new panel version, entry version of all genes was always set to the previous panel version, automatically. This happened for genes introduced in the panel in the previous version or 10 panel versions before. We reasoned that for this reason that field was not informative and that's why we changed it. Sorry if it is confusing but the idea was to make it very clear when a gene is introduced in a panel for the very first time.
There were several problems with inheritance terms and we made changes to hopefully fix the problem that panels could not be exported/imported and updated maintaining all available info from before. We have tested quite much before introducing these changes, but please let us know if you notice something that shouldn't be happening! 🙏🏻
For what's concerning the emails you are totally right, some things are not quite understandable by the software user. The most cryptic entries I would say are meant to be understood by scout administrators or developers in other institutions, so if you read something that makes no sense at all to you, please just ignore the info. Regarding entries that update/change software behaviour, then it would be ideal that that information is understood by the users, so we'll try to be more clear with the descriptions. Sometimes it is hard because you have to describe a new feature of a fix to a bug with only one line. But If the message is not clear please reach out and ask, either to our emails or as you just did here! 👍🏻 But understood, we'll definitely make an effort to create clearer descriptions of the changes for the upcoming releases! |
Hi,
When looking at our gene panels (https://scout.scilifelab.se/panels), I noticed that the entry version has disappeared from all entries in the panels (I've checked six different panels).
The panel Newborn screening, metabolic has also lost all inheritance terms.
Was this intended?
thanks,
Ingegerd
The text was updated successfully, but these errors were encountered: