Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Apptag version in delivery report #4076

Merged
merged 13 commits into from
Jan 15, 2025
Merged

Hide Apptag version in delivery report #4076

merged 13 commits into from
Jan 15, 2025

Conversation

beatrizsavinhas
Copy link
Contributor

@beatrizsavinhas beatrizsavinhas commented Jan 13, 2025 •
edited
Loading

Description

Closes #4000.

Changed

  • Remove application version from the delivery report template.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Run 'cg generate delivery-report humanestarfish`

Expected test outcome

  • Check that that only the application tag is shown in the delivery report.
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by BSV
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Deploy this branch on hasta, production

@beatrizsavinhas beatrizsavinhas marked this pull request as ready for review January 14, 2025 12:40
@beatrizsavinhas beatrizsavinhas requested a review from a team as a code owner January 14, 2025 12:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@beatrizsavinhas
Copy link
Contributor Author

beatrizsavinhas commented Jan 15, 2025 •
edited
Loading

With main:

Screenshot 2025-01-14 at 17 12 28
Screenshot 2025-01-14 at 17 10 12

With this branch:

Screenshot 2025-01-15 at 09 13 40 Screenshot 2025-01-15 at 09 14 01

@beatrizsavinhas beatrizsavinhas merged commit 0c665e9 into master Jan 15, 2025
10 checks passed
@beatrizsavinhas beatrizsavinhas deleted the 4000-hide-apptag-version-from-delivery-report branch January 15, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrOertlin ChrOertlin ChrOertlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide Apptag version in all delivery reports
2 participants
@beatrizsavinhas @ChrOertlin