Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Balsamic QC #3918

Open
2 tasks
Vince-janv opened this issue Nov 5, 2024 · 5 comments
Open
2 tasks

Remove Balsamic QC #3918

Vince-janv opened this issue Nov 5, 2024 · 5 comments
Assignees
Labels
technical-debt Complicating development in the repo

Comments

@Vince-janv
Copy link
Contributor

Vince-janv commented Nov 5, 2024

Descripion

The workflow Balsamic QC has never and will probably never be used by customers. We are supporting it and maintaining logic for cases with this workflow set. Removing it would reduce the amount of logic we have to maintain.

User story

As a developer,
I want to remove the Balsamic QC workflow and all code tied to it,
So that we don't have to maintain unused code.

Work impact

Answer the following questions:

  • How much time would be saved by implementing this feature on a weekly basis?
    • This would reduce development time in all projects dealing with the order flow
  • How many users are affected by this issue?
    • All developers
  • Are customers affected by this issue?
    • No customers are using this

Acceptance Criteria

  • Customers can no longer place Balsamic QC orders
  • All logic partaining to Balsamic QC is removed

Notes

  • The order type should also be removed from the FE
  • All 8 cases in the database with data_analysis='balsamic-qc' can be set to just 'balsamic'
@Vince-janv Vince-janv added the technical-debt Complicating development in the repo label Nov 6, 2024
@henrikstranneheim
Copy link
Contributor

Remove QC code here: #3924

@henrikstranneheim henrikstranneheim self-assigned this Nov 7, 2024
@henrikstranneheim
Copy link
Contributor

Hermes: Clinical-Genomics/hermes#128

@henrikstranneheim
Copy link
Contributor

@diitaz93
Copy link
Contributor

Initial technical refinement/ questions: Listing places where we would need to touch any code

  • Balsamic QC is present in the following repositories (at least):

  • cg

  • Hermes

  • Servers

  • Trailblazer

  • CiGRID

  • clinical-genomics-ui

  • Any other?? Arnold? Janus?

  • How would this affect Scout?

  • How would this affect gens?

  • How would this affect locusDB?

  • How would this affect Housekeeper? Is there a tag for balsamic-qc? What to do with files tagged with this?

We could start by removing BalsamicQC as an order option in the order portal, so that we don't get any more data

@diitaz93
Copy link
Contributor

Side idea: Should we have a protocol for deprecating workflows? This can be a chance to create this protocol and documenting it

@diitaz93 diitaz93 self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Complicating development in the repo
Projects
None yet
Development

No branches or pull requests

3 participants