Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation of sample sheets hindering cleaning of Illumina runs #3915

Closed
diitaz93 opened this issue Nov 5, 2024 · 1 comment · Fixed by #4012
Closed

Generation of sample sheets hindering cleaning of Illumina runs #3915

diitaz93 opened this issue Nov 5, 2024 · 1 comment · Fixed by #4012

Comments

@diitaz93
Copy link
Contributor

diitaz93 commented Nov 5, 2024

Description

  • Illumina sequencing runs are not getting cleaned
  • The cleaning relies on the timestamp of the sequencing folder (cleaning runs older than certain time)
  • The timestamps of the folders seems to be always no more than 10 minutes old
  • @Vince-janv did some experiments (see https://github.com/Clinical-Genomics/bug-reports/issues/16) and concluded that the system in charge of the generation of the sample sheets is the one updating the timestamp of the sequencing run folders (cg demultiplex sample-sheet create-all)
  • The generation of the sample sheets is designed to overwrite the sample sheet in the directory (using os.link()) with the sample sheet in housekeeper if the later passes validation. This was designed to overwrite any sample sheet in an old format fetched from pdc.

To Reproduce
Turn off the sample sheet generator timer and the directories don't get their timestamps updated
See https://github.com/Clinical-Genomics/bug-reports/issues/16

Expected behavior
An Illumina sequencing run directory which has a valid sample sheet will not have its time stamp updated.

@Vince-janv
Copy link
Contributor

Vince-janv commented Nov 14, 2024

Technical refinement

In cg.apps.demultiplex.sample_sheet.api.IlluminaSampleSheetService._use_sample_sheet_from_housekeeper add the line if sample_sheet_path.samefile(run_directory_data.sample_sheet_path): before the overwriting of samplesheet

Make sure to except FileNotFountError

@ahdamin ahdamin self-assigned this Dec 10, 2024
@ahdamin ahdamin linked a pull request Dec 10, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants