Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping links that report 429 and external links with hashes #735

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Skipping links that report 429 and external links with hashes #735

merged 2 commits into from
Mar 13, 2024

Conversation

dmundra
Copy link
Contributor

@dmundra dmundra commented Mar 5, 2024

Reducing the amount of links we need to worry about fixing.

@dmundra dmundra self-assigned this Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Cypress Test Results

12 tests   12 ✔️  47s ⏱️
11 suites    0 💤
  5 files      0 ❌

Results for commit c785120.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Pa11y testing results 
> pa11y-ci:sitemap
> pa11y-ci --sitemap http://127.0.0.1:4000/sitemap.xml --sitemap-find https://accessibility.civicactions.com --sitemap-replace http://127.0.0.1:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 127 URLs:
 > http://localhost:4000/guide/champions-program - 0 errors
 > http://localhost:4000/guide/design - 0 errors
 > http://localhost:4000/guide/documents - 0 errors
 > http://localhost:4000/guide/events - 0 errors
 > http://localhost:4000/guide/glossary - 0 errors
 > http://localhost:4000/guide/history - 0 errors
 > http://localhost:4000/guide/identity-language - 0 errors
 > http://localhost:4000/guide/introduction - 0 errors
 > http://localhost:4000/guide/onboarding-staff - 0 errors
 > http://localhost:4000/guide/organizations - 0 errors
 > http://localhost:4000/guide/plain-language - 0 errors
 > http://localhost:4000/guide/resources - 0 errors
 > http://localhost:4000/guide/semantic-html - 0 errors
 > http://localhost:4000/guide/social-media - 0 errors
 > http://localhost:4000/guide/tools - 0 errors
 > http://localhost:4000/guide/training - 0 errors
 > http://localhost:4000/about/people/allison-carroll - 0 errors
 > http://localhost:4000/about/people/civicactions - 0 errors
 > http://localhost:4000/about/people/daniel-mundra - 0 errors
 > http://localhost:4000/about/people/jack-haas - 0 errors
 > http://localhost:4000/about/people/jennifer-houde - 0 errors
 > http://localhost:4000/about/people/jonathan-bourland - 0 errors
 > http://localhost:4000/about/people/luke-fretwell - 0 errors
 > http://localhost:4000/about/people/michelle-kang - 0 errors
 > http://localhost:4000/about/people/mike-gifford - 0 errors
 > http://localhost:4000/about/people/nira-datta - 0 errors
 > http://localhost:4000/about/people/vanessa-luxen - 0 errors
 > http://localhost:4000/personas/accessibility-avery - 0 errors
 > http://localhost:4000/personas/designer-darcy - 0 errors
 > http://localhost:4000/personas/engineer-emery - 0 errors
 > http://localhost:4000/personas/procurement-parker - 0 errors
 > http://localhost:4000/personas/qa-quincy - 0 errors
 > http://localhost:4000/personas/remote-raz - 0 errors
 > http://localhost:4000/playbook/AT - 0 errors
 > http://localhost:4000/playbook/ai-and-ia - 0 errors
 > http://localhost:4000/playbook/authoring - 0 errors
 > http://localhost:4000/playbook/automated-testing - 0 errors
 > http://localhost:4000/playbook/checklists - 0 errors
 > http://localhost:4000/playbook/community - 0 errors
 > http://localhost:4000/playbook/distributed-teams - 0 errors
 > http://localhost:4000/playbook/documents - 0 errors
 > http://localhost:4000/playbook/follow-global-initiatives - 0 errors
 > http://localhost:4000/playbook/manual-testing - 0 errors
 > http://localhost:4000/playbook/personalization - 0 errors
 > http://localhost:4000/playbook/practice - 0 errors
 > http://localhost:4000/playbook/pwd - 0 errors
 > http://localhost:4000/playbook/roles - 0 errors
 > http://localhost:4000/playbook/statements - 0 errors
 > http://localhost:4000/playbook/training - 0 errors
 > http://localhost:4000/posts/4-ways-to-improve-government-accessibility-through-open-source - 0 errors
 > http://localhost:4000/posts/hello-world - 0 errors
 > http://localhost:4000/posts/whitehouse.gov-beginning-an-accessibility-journey - 0 errors
 > http://localhost:4000/posts/gcn-accessibility-compliance-as-code - 0 errors
 > http://localhost:4000/posts/improve-government-accessibility-through-open-source - 0 errors
 > http://localhost:4000/posts/govtech-how-will-biden-transform-government-website-accessibility - 0 errors
 > http://localhost:4000/posts/automated-accessibility-testing-leveraging-github-actions-and-pa11y-ci-with-axe - 0 errors
 > http://localhost:4000/posts/government-accessibility-and-the-cms-problem - 0 errors
 > http://localhost:4000/posts/at-banter-podcast - 0 errors
 > http://localhost:4000/posts/mvp-playbook - 0 errors
 > http://localhost:4000/posts/mvp-guide - 0 errors
 > http://localhost:4000/posts/smashingmag-baking-in-accessibility-testing - 0 errors
 > http://localhost:4000/posts/qa-with-mike-gifford-accessibility-in-civic-tech - 0 errors
 > http://localhost:4000/posts/launching-a-community-of-practice-for-accessibility-in-government-services - 0 errors
 > http://localhost:4000/posts/pre-GAAD-Authoring-Tools-Built-in-Accessibility - 0 errors
 > http://localhost:4000/posts/website-analytics - 0 errors
 > http://localhost:4000/posts/how-we-scale-inclusive-website-content-with-automated-testing-and-open-source-tools - 0 errors
 > http://localhost:4000/posts/social-media-accessibility-guide - 0 errors
 > http://localhost:4000/posts/plain-language-accessibility-guide - 0 errors
 > http://localhost:4000/posts/heart-accessibility - 0 errors
 > http://localhost:4000/posts/scanning-over-two-million-gov-pages - 0 errors
 > http://localhost:4000/posts/gsa-machine-readable-acr - 0 errors
 > http://localhost:4000/posts/CivicActions-Creates-Open-Product-Accessibility-Template - 0 errors
 > http://localhost:4000/posts/how-drupal-helps-us-bake-accessibility-into-every-project - 0 errors
 > http://localhost:4000/posts/CivicActions-Accessibility-Pledge - 0 errors
 > http://localhost:4000/posts/Talking-Drupal-Podcast - 0 errors
 > http://localhost:4000/posts/Talking-Drupal-Podcast-382 - 0 errors
 > http://localhost:4000/posts/governments-accessibility-opensource - 0 errors
 > http://localhost:4000/posts/FOSDEM-ccessibility-OpenSource - 0 errors
 > http://localhost:4000/posts/opensource-automated-accessibility-testing - 0 errors
 > http://localhost:4000/posts/helping-disabled-veterans-check-in-designing-an-accessibility-map - 0 errors
 > http://localhost:4000/posts/daniel-mundra-diving-into-drupal - 0 errors
 > http://localhost:4000/posts/how-omb-can-improve-gov-accessibility - 0 errors
 > http://localhost:4000/posts/fix-accessibility-bugs - 0 errors
 > http://localhost:4000/posts/five-reasons-to-get-excited-about-governmentwide-section-508-assessment-criteria - 0 errors
 > http://localhost:4000/projects/drupal - 0 errors
 > http://localhost:4000/projects/uswds-color - 0 errors
 > http://localhost:4000/projects/uswds - 0 errors
 > http://localhost:4000/roles/content-designer - 0 errors
 > http://localhost:4000/roles/developer - 0 errors
 > http://localhost:4000/roles/executive - 0 errors
 > http://localhost:4000/roles/operations - 0 errors
 > http://localhost:4000/roles/procurement - 0 errors
 > http://localhost:4000/roles/product-manager - 0 errors
 > http://localhost:4000/roles/project-manager - 0 errors
 > http://localhost:4000/roles/ux-designer - 0 errors
 > http://localhost:4000/topics/design - 0 errors
 > http://localhost:4000/topics/disability-type - 0 errors
 > http://localhost:4000/topics/process-policies - 0 errors
 > http://localhost:4000/topics/roles - 0 errors
 > http://localhost:4000/topics/testing - 0 errors
 > http://localhost:4000/topics/tools - 0 errors
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/accessibility - 0 errors
 > http://localhost:4000/agile - 0 errors
 > http://localhost:4000/analytics - 0 errors
 > http://localhost:4000/calendar - 0 errors
 > http://localhost:4000/colophon - 0 errors
 > http://localhost:4000/conduct - 0 errors
 > http://localhost:4000/about/contact - 0 errors
 > http://localhost:4000/guide/ - 0 errors
 > http://localhost:4000/heart - 0 errors
 > http://localhost:4000/help - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/news/ - 0 errors
 > http://localhost:4000/about/join - 0 errors
 > http://localhost:4000/license - 0 errors
 > http://localhost:4000/okrs - 0 errors
 > http://localhost:4000/open - 0 errors
 > http://localhost:4000/about/people/ - 0 errors
 > http://localhost:4000/personas/ - 0 errors
 > http://localhost:4000/playbook/ - 0 errors
 > http://localhost:4000/projects/ - 0 errors
 > http://localhost:4000/roles/ - 0 errors
 > http://localhost:4000/search - 0 errors
 > http://localhost:4000/services - 0 errors
 > http://localhost:4000/topics/ - 0 errors
 > http://localhost:4000/VPAT/Drupal9AccessibilityConformanceReport-December2020.html - 0 errors

✔ 127/127 URLs passed

@dmundra dmundra changed the title Skipping links that report 429 Skipping links that report 429 and external links with hashes Mar 5, 2024
@dmundra dmundra marked this pull request as ready for review March 5, 2024 21:53
@dmundra dmundra requested a review from mgifford March 5, 2024 21:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Pa11y testing results 
> pa11y-ci:sitemap
> pa11y-ci --sitemap http://127.0.0.1:4000/sitemap.xml --sitemap-find https://accessibility.civicactions.com --sitemap-replace http://127.0.0.1:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 127 URLs:
 > http://localhost:4000/guide/champions-program - 0 errors
 > http://localhost:4000/guide/design - 0 errors
 > http://localhost:4000/guide/documents - 0 errors
 > http://localhost:4000/guide/events - 0 errors
 > http://localhost:4000/guide/glossary - 0 errors
 > http://localhost:4000/guide/history - 0 errors
 > http://localhost:4000/guide/identity-language - 0 errors
 > http://localhost:4000/guide/introduction - 0 errors
 > http://localhost:4000/guide/onboarding-staff - 0 errors
 > http://localhost:4000/guide/organizations - 0 errors
 > http://localhost:4000/guide/plain-language - 0 errors
 > http://localhost:4000/guide/resources - 0 errors
 > http://localhost:4000/guide/semantic-html - 0 errors
 > http://localhost:4000/guide/social-media - 0 errors
 > http://localhost:4000/guide/tools - 0 errors
 > http://localhost:4000/guide/training - 0 errors
 > http://localhost:4000/about/people/allison-carroll - 0 errors
 > http://localhost:4000/about/people/civicactions - 0 errors
 > http://localhost:4000/about/people/daniel-mundra - 0 errors
 > http://localhost:4000/about/people/jack-haas - 0 errors
 > http://localhost:4000/about/people/jennifer-houde - 0 errors
 > http://localhost:4000/about/people/jonathan-bourland - 0 errors
 > http://localhost:4000/about/people/luke-fretwell - 0 errors
 > http://localhost:4000/about/people/michelle-kang - 0 errors
 > http://localhost:4000/about/people/mike-gifford - 0 errors
 > http://localhost:4000/about/people/nira-datta - 0 errors
 > http://localhost:4000/about/people/vanessa-luxen - 0 errors
 > http://localhost:4000/personas/accessibility-avery - 0 errors
 > http://localhost:4000/personas/designer-darcy - 0 errors
 > http://localhost:4000/personas/engineer-emery - 0 errors
 > http://localhost:4000/personas/procurement-parker - 0 errors
 > http://localhost:4000/personas/qa-quincy - 0 errors
 > http://localhost:4000/personas/remote-raz - 0 errors
 > http://localhost:4000/playbook/AT - 0 errors
 > http://localhost:4000/playbook/ai-and-ia - 0 errors
 > http://localhost:4000/playbook/authoring - 0 errors
 > http://localhost:4000/playbook/automated-testing - 0 errors
 > http://localhost:4000/playbook/checklists - 0 errors
 > http://localhost:4000/playbook/community - 0 errors
 > http://localhost:4000/playbook/distributed-teams - 0 errors
 > http://localhost:4000/playbook/documents - 0 errors
 > http://localhost:4000/playbook/follow-global-initiatives - 0 errors
 > http://localhost:4000/playbook/manual-testing - 0 errors
 > http://localhost:4000/playbook/personalization - 0 errors
 > http://localhost:4000/playbook/practice - 0 errors
 > http://localhost:4000/playbook/pwd - 0 errors
 > http://localhost:4000/playbook/roles - 0 errors
 > http://localhost:4000/playbook/statements - 0 errors
 > http://localhost:4000/playbook/training - 0 errors
 > http://localhost:4000/posts/4-ways-to-improve-government-accessibility-through-open-source - 0 errors
 > http://localhost:4000/posts/hello-world - 0 errors
 > http://localhost:4000/posts/whitehouse.gov-beginning-an-accessibility-journey - 0 errors
 > http://localhost:4000/posts/gcn-accessibility-compliance-as-code - 0 errors
 > http://localhost:4000/posts/improve-government-accessibility-through-open-source - 0 errors
 > http://localhost:4000/posts/govtech-how-will-biden-transform-government-website-accessibility - 0 errors
 > http://localhost:4000/posts/automated-accessibility-testing-leveraging-github-actions-and-pa11y-ci-with-axe - 0 errors
 > http://localhost:4000/posts/government-accessibility-and-the-cms-problem - 0 errors
 > http://localhost:4000/posts/at-banter-podcast - 0 errors
 > http://localhost:4000/posts/mvp-playbook - 0 errors
 > http://localhost:4000/posts/mvp-guide - 0 errors
 > http://localhost:4000/posts/smashingmag-baking-in-accessibility-testing - 0 errors
 > http://localhost:4000/posts/qa-with-mike-gifford-accessibility-in-civic-tech - 0 errors
 > http://localhost:4000/posts/launching-a-community-of-practice-for-accessibility-in-government-services - 0 errors
 > http://localhost:4000/posts/pre-GAAD-Authoring-Tools-Built-in-Accessibility - 0 errors
 > http://localhost:4000/posts/website-analytics - 0 errors
 > http://localhost:4000/posts/how-we-scale-inclusive-website-content-with-automated-testing-and-open-source-tools - 0 errors
 > http://localhost:4000/posts/social-media-accessibility-guide - 0 errors
 > http://localhost:4000/posts/plain-language-accessibility-guide - 0 errors
 > http://localhost:4000/posts/heart-accessibility - 0 errors
 > http://localhost:4000/posts/scanning-over-two-million-gov-pages - 0 errors
 > http://localhost:4000/posts/gsa-machine-readable-acr - 0 errors
 > http://localhost:4000/posts/CivicActions-Creates-Open-Product-Accessibility-Template - 0 errors
 > http://localhost:4000/posts/how-drupal-helps-us-bake-accessibility-into-every-project - 0 errors
 > http://localhost:4000/posts/CivicActions-Accessibility-Pledge - 0 errors
 > http://localhost:4000/posts/Talking-Drupal-Podcast - 0 errors
 > http://localhost:4000/posts/Talking-Drupal-Podcast-382 - 0 errors
 > http://localhost:4000/posts/governments-accessibility-opensource - 0 errors
 > http://localhost:4000/posts/FOSDEM-ccessibility-OpenSource - 0 errors
 > http://localhost:4000/posts/opensource-automated-accessibility-testing - 0 errors
 > http://localhost:4000/posts/helping-disabled-veterans-check-in-designing-an-accessibility-map - 0 errors
 > http://localhost:4000/posts/daniel-mundra-diving-into-drupal - 0 errors
 > http://localhost:4000/posts/how-omb-can-improve-gov-accessibility - 0 errors
 > http://localhost:4000/posts/fix-accessibility-bugs - 0 errors
 > http://localhost:4000/posts/five-reasons-to-get-excited-about-governmentwide-section-508-assessment-criteria - 0 errors
 > http://localhost:4000/projects/drupal - 0 errors
 > http://localhost:4000/projects/uswds-color - 0 errors
 > http://localhost:4000/projects/uswds - 0 errors
 > http://localhost:4000/roles/content-designer - 0 errors
 > http://localhost:4000/roles/developer - 0 errors
 > http://localhost:4000/roles/executive - 0 errors
 > http://localhost:4000/roles/operations - 0 errors
 > http://localhost:4000/roles/procurement - 0 errors
 > http://localhost:4000/roles/product-manager - 0 errors
 > http://localhost:4000/roles/project-manager - 0 errors
 > http://localhost:4000/roles/ux-designer - 0 errors
 > http://localhost:4000/topics/design - 0 errors
 > http://localhost:4000/topics/disability-type - 0 errors
 > http://localhost:4000/topics/process-policies - 0 errors
 > http://localhost:4000/topics/roles - 0 errors
 > http://localhost:4000/topics/testing - 0 errors
 > http://localhost:4000/topics/tools - 0 errors
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/accessibility - 0 errors
 > http://localhost:4000/agile - 0 errors
 > http://localhost:4000/analytics - 0 errors
 > http://localhost:4000/calendar - 0 errors
 > http://localhost:4000/colophon - 0 errors
 > http://localhost:4000/conduct - 0 errors
 > http://localhost:4000/about/contact - 0 errors
 > http://localhost:4000/guide/ - 0 errors
 > http://localhost:4000/heart - 0 errors
 > http://localhost:4000/help - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/news/ - 0 errors
 > http://localhost:4000/about/join - 0 errors
 > http://localhost:4000/license - 0 errors
 > http://localhost:4000/okrs - 0 errors
 > http://localhost:4000/open - 0 errors
 > http://localhost:4000/about/people/ - 0 errors
 > http://localhost:4000/personas/ - 0 errors
 > http://localhost:4000/playbook/ - 0 errors
 > http://localhost:4000/projects/ - 0 errors
 > http://localhost:4000/roles/ - 0 errors
 > http://localhost:4000/search - 0 errors
 > http://localhost:4000/services - 0 errors
 > http://localhost:4000/topics/ - 0 errors
 > http://localhost:4000/VPAT/Drupal9AccessibilityConformanceReport-December2020.html - 0 errors

✔ 127/127 URLs passed

mgifford
mgifford reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@mgifford mgifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to figure out what the flag you add does. I didn't see it here https://linkchecker.github.io/linkchecker/man/linkchecker.html

@dmundra
Copy link
Contributor Author

dmundra commented Mar 6, 2024

I'm trying to figure out what the flag you add does. I didn't see it here https://linkchecker.github.io/linkchecker/man/linkchecker.html

I am actually using this https://github.com/gjtorikian/html-proofer to check links

mgifford
mgifford approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@mgifford mgifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dmundra dmundra merged commit 5799b9b into main Mar 13, 2024
8 of 9 checks passed
@dmundra dmundra deleted the dmundra-patch-1 branch March 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgifford mgifford mgifford approved these changes

Assignees

@dmundra dmundra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmundra @mgifford