-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Support #52
Comments
So I've started playing around with this and have at this stage just glossed over two main areas of concern:
The first I've kind of worked around, but the second will be difficult to make async but keep the iterator. I'm guessing the iterators are done this way to keep the memory footprint small on large batches? One way these kinds of methods can be made async is using something like Rx, but that's a significant dependency to pull in... The |
Wow, this is awesome. Asyc support is definitely something our team has kicked around, thank you for taking the initiative! I won't be able to dig into this today, but please don't let that stop you - be in touch soon. |
No problem :) right now all I've done is make things async, without much thought for whether or not the existing code could benefit from it more. I'd love to get some thoughts from you who are familiar with the codebase and where docs need to be updated. |
It'd be good to use async methods for dealing with the HTTP streams;
GetResponseStreamAsync
overGetResponseStream
for example. Unless you wanted to keep synchronous versions of the client calls for backwards compatibility it would be a lot of breaking changes.This is something I'm happy to check out.
The text was updated successfully, but these errors were encountered: