Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling mismatch #515

Open
CoMPaTech opened this issue Jan 21, 2025 · 2 comments
Open

Exception handling mismatch #515

CoMPaTech opened this issue Jan 21, 2025 · 2 comments

Comments

@CoMPaTech
Copy link

CoMPaTech commented Jan 21, 2025

Just a quick note (might do a PR against it) - colleague just ran into this:

raise NoResponseFromController(f"APDU Abort Reason : {response}")

The exceptions L116 and L120 won't work since it's incepting itself with response (which is only valid if the try: is successful, so this will never be reached). And yes this was obviously done through awaiting _write() instead of properly consuming write() without expecting an answer, but the errors generated would be the same obviously.

@ChristianTremblay
Copy link
Owner

oups

@CoMPaTech
Copy link
Author

Willing to correct it - but didn't have time to start writing a PR just yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants