Test non-empty IndexSet.limitSpanningRange, documenting why max is inside #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very very very into test- and documentation-only PRs! But I do have one suggestion. I think it fits better with convention when the first doc line is more succinct. Do you think it would be possible to keep that shorter and move the additional info into the discussion section? |
|
Oh yeah, makes sense to keep the first line shorter. Maybe the doc-comment part can also be dropped since this sounds like a trivial 'insight' even though it took me a minute to realize this. The tests might be sufficient to self-document the behavior, though, depending on your tastes :) |
|
Nah, I like it! Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the implementation, I wondered if
...instead of..<was intentional -- but writing the test showed that, yes of course I want the largest element to be part of the range :)