Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown commands send a message instead of failing #5675

Open
4 tasks done
hemirt opened this issue Oct 24, 2024 · 3 comments
Open
4 tasks done

Unknown commands send a message instead of failing #5675

hemirt opened this issue Oct 24, 2024 · 3 comments
Labels
not our bug Behaviour that feels like a bug, but isn't really something we can work around. OS/Qt "bugs"

Comments

@hemirt
Copy link
Contributor

hemirt commented Oct 24, 2024

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

Sending an unknown command sends a message instead
{35881F79-D4C6-4237-8C66-DD92AB2795DE}

does not happen with stable, happens with nightly

this should fail instead of sending a message, if you mistype your command (e.g. block/ban) then instead you send a message

Screenshots

No response

OS and Chatterino Version

Chatterino Nightly 2.5.1 (commit f66bc37) built on 2024-10-24 with Qt 6.7.1, MSVC 194134123, Crashpad Running on Windows 11 Version 24H2, kernel: 10.0.26120

@hemirt hemirt added the issue-report An issue reported by a user. label Oct 24, 2024
@pajlada pajlada added not our bug Behaviour that feels like a bug, but isn't really something we can work around. OS/Qt "bugs" and removed issue-report An issue reported by a user. labels Oct 24, 2024
@hemirt
Copy link
Contributor Author

hemirt commented Oct 24, 2024

The behaviour did change between versions, atleast in twitch chat, it tells me "Unrecognized command" and the message is not sent, whilst in nightly chatterino, the message gets sent. I believe it should probably mimic similar behaviour, since you can have your own chatterino commands, I'd assume you would not think that it would just send the message.

... that is extremely unsafe, especially if you want to send a whisper or block someone and you mistype it.

I believe chatterino should keep a list of possible commands and prompt you just in case you actually want to try sending an unknown command (e.g. before it is supported by this list), instead of just sending it straight away.

Mentioned in https://twitch.uservoice.com/forums/310213-developers/suggestions/48972260-improve-error-messages-for-send-chat-message & https://discord.com/channels/504015559252377601/504015559252377605/1296195692838125578

This mentions that the command is dropped, but in my observation, the message is NOT dropped, rather just sent without the command name.

As a side note:
I did get the "your message is being checked by mods", when a vpn I used was shadowbanned (and the mods did not receive the message), seems like the same error message is used on way too many things.

@pajlada
Copy link
Member

pajlada commented Oct 24, 2024

The behaviour did change between versions

We are likely to revert the Chat Send Protocol before it actually makes it into a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not our bug Behaviour that feels like a bug, but isn't really something we can work around. OS/Qt "bugs"
Projects
None yet
Development

No branches or pull requests

3 participants