Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MAX_REQUEST_BLOB_SIDECARS and MAX_BLOBS_PER_BLOCK configurable #7172

Open
ensi321 opened this issue Oct 17, 2024 · 0 comments
Open

Make MAX_REQUEST_BLOB_SIDECARS and MAX_BLOBS_PER_BLOCK configurable #7172

ensi321 opened this issue Oct 17, 2024 · 0 comments
Labels
meta-feature-request Issues to track feature requests.

Comments

@ensi321
Copy link
Contributor

ensi321 commented Oct 17, 2024 •
edited
Loading

Problem description

In ethereum/consensus-specs#3817, MAX_BLOBS_PER_BLOCK is moved from preset to config.

This poses a challenge in Lodestar since BlobSidecarsByRootRequest - a fixed length ssz container depends on it but types package has no access to chain.config.

Solution description

I believe this is the only place in the spec has a ssz container for which its definition relies on a variable from config.

We can either make a one time exception and define BlobSidecarsByRootRequest ssz in beacon-node or further refactor to be more future proof if such scenario happens again.

cc. @g11tech

Additional context

No response
@ensi321 ensi321 added the meta-feature-request Issues to track feature requests. label Oct 17, 2024
@ensi321 ensi321 changed the title Move MAX_BLOBS_PER_BLOCK from preset to config Make MAX_REQUEST_BLOB_SIDECARS and MAX_BLOBS_PER_BLOCK configurable Oct 17, 2024
This was referenced Oct 17, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-feature-request Issues to track feature requests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ensi321