Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially TreeBacked block #3415

Closed
dapplion opened this issue Nov 5, 2021 · 1 comment
Closed

Partially TreeBacked block #3415

dapplion opened this issue Nov 5, 2021 · 1 comment
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

dapplion commented Nov 5, 2021

Describe the bug

We don't need to serve proofs of blocks and block data is immutable. Having a block fully TreeBacked is a waste of memory and performance to traverse the tree multiple times.

Expected behavior

Find a different strategy to cache hashTreeRoots and efficiently hash the block once and keep only some tree roots for latter signature verification.
@dapplion dapplion added prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance. labels Nov 5, 2021
@dapplion dapplion mentioned this issue Nov 29, 2021
Closed
26 tasks
@dapplion
Copy link
Contributor Author

With #3760 blocks are not longer tree backed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dapplion