-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To-do list for upgrade command #5
Comments
This issue originally referred to the upgrade from "pre-1.0" to "1.0" tilesets. Some of the bullet points have therefore been addressed already, or are tracked in dedicated issues, or have become obsolete (the latter also insofar that The question of the scope of the There is a (somewhat preliminary) set of options in the Beyond that, one could consider to extend the |
The migration guide gives a few hints about how to "emulate" several features of the previous tile formats in glTF. I'll try to start sorting out which of these steps could be part of an automated process. On the highest level, the entry point would be to add this functionality to the (The case of CMPT is special in many ways, and has to be discussed separately) The actual upgrade functionality would then be implemented in the (The latter has some constraints, though. It may not be done for implicit tile content, for example....) A large part of the infrastructure for this kind of modification already exists. For example, the "The migration function receives a B3DM/PNTS/I3DM buffer. It creates an equivalent GLB buffer" And what "equivalent" means, is sorted out in the following sections Feature detection and error handlingA large part of the features from the legacy tile formats can be migrated automatically. In the first versions, there will be some things that are not migrated yet, but will be migrated in future versions. But there also are cases that can "never" be migrated automatically. One overarching question is how to handle that. A high-level, straightforward approach could be to examine the input data and its Feature Table and Batch Table, and if it contains anything that can not be migrated, then just print a warning and leave the content unmodified. The
|
Just to have a back-link here: There are some points about a possible upgrade from 3D Tiles 1.0 to 1.1 summarized in CesiumGS/3d-tiles#592 (comment) that may have to be taken into account here. |
A short update: Most of the functionality for the generalized upgrade has been implemented in #41 and #52 . The remaining (open) task is that of upgrading CMPT files. There are some caveats (as described in detail in the previous comment), so this may not be tackled immediately. But the approach of "merging the (resulting) GLBs" could be worth a try, because for the kind of data that usually appears as tile content, this could be implementable with glTF-Transform with reasonable effort. |
A small update: The conversion of CMPT to GLB has been implemented as part of #117 (with caveats, corner cases, and limitations laid out in the PR, and the comment above) Now, from the list that was posted when we were still young, there are two main points left:
The latter made its way into the specification, But it was pretty late, and caused some "disruption" like CesiumGS/cesium@4b3b418 and many (other) ("legacy") data sets that are "invalid" due to some alignment errors. Some of this is already handled via the functionality of converting the "legacy" tile formats to GLB. But one could make a case for offering a command that just takes contents like B3DM and fixes the alignment requirements, with as few other changes as possible. Maybe this should be tracked in a dedicated issue...? |
@javagl I think this issue is closeable now, after 6 years 😄
Feel free to open a separate issue. Though this would be lower priority. |
🎉 👴 A command for fixing the alignment may have low-priority, but ... it should also not be sooo difficult, so maybe I'll try to sneak it in, as a recreational task for some boring weekend. Tracked at #134 |
Tentative changes for
1.0
that should be handled in theupgrade
commandasset.gltfUpAxis
removedBATCHID
to_BATCHID
Progress is in https://github.com/AnalyticalGraphicsInc/3d-tiles-tools/tree/2.0-tools
The text was updated successfully, but these errors were encountered: