Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corpus categories in JSON schema #1738

Open
lukavdplas opened this issue Jan 15, 2025 · 0 comments
Open

Corpus categories in JSON schema #1738

lukavdplas opened this issue Jan 15, 2025 · 0 comments
Assignees
@JeltevanBoheemen
Labels
backend changes to the django backend code quality code & performance improvements that do not affect user functionality frontend changes to the angular frontend

Comments

@lukavdplas
Copy link
Contributor

To show options for corpus categories, the corpus form in the frontend currently hard-codes the categories. To maintain a single source of truth, the categories should be fetched from the backend.

Suggestion:

  • Add the options for categories in the corpus JSON schema (instead of typing this fields as any string)
  • Add API endpoint for the JSON schema API endpoint for corpus JSON schema #1737
  • Adjust the form logic to get the options from the schema endpoint
@lukavdplas lukavdplas added code quality code & performance improvements that do not affect user functionality frontend changes to the angular frontend backend changes to the django backend labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeltevanBoheemen JeltevanBoheemen

Labels
backend changes to the django backend code quality code & performance improvements that do not affect user functionality frontend changes to the angular frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeltevanBoheemen @lukavdplas