Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min/max data in corpus model: store as integer #1733

Open
lukavdplas opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1742
Open

Min/max data in corpus model: store as integer #1733

lukavdplas opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1742
Assignees
@lukavdplas
Labels
backend changes to the django backend frontend changes to the angular frontend

Comments

@lukavdplas
Copy link
Contributor

The CorpusConfiguration model includes the min/max data for the corpus, which is used to show/filter metadata for each corpus in the corpus overview. The page only shows the date as a year though, which is sufficient.

Suggestion:

  • Change the field to an integer
  • When importing a corpus definition, if min/max is a date, extract the year.
  • Change the corpus JSON definition API to use an integer (view/schema/frontend functions /etc)
  • Change the corpus form to use number input
@lukavdplas lukavdplas added frontend changes to the angular frontend backend changes to the django backend labels Jan 15, 2025
@lukavdplas lukavdplas self-assigned this Jan 21, 2025
@lukavdplas lukavdplas linked a pull request Jan 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukavdplas lukavdplas

Labels
backend changes to the django backend frontend changes to the angular frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store corpus date as integer CentreForDigitalHumanities/I-analyzer
1 participant
@lukavdplas