Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more convenient convenience method to create a sampler! #136

Open
lbluque opened this issue Sep 2, 2021 · 1 comment
Open

A more convenient convenience method to create a sampler! #136

lbluque opened this issue Sep 2, 2021 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@lbluque
Copy link
Collaborator

lbluque commented Sep 2, 2021

Is your feature request related to a problem? Please describe.
Please describe the problem you are trying to solve.
Not related to a problem, but I find myself creating to many ensembles that I rarely use directly.
Except for obtaining an initial occupancy, but other than that not really used for anything else.

Describe the solution you'd like
Please describe the desired behavior.
Perhaps having a convenience constructor in the sampler to create directly from a Cluster Expansion like so,
Sampler.from_cluster_expansion(expansion, supercell_matrix, ...all other goodies needed)

Describe alternatives you've considered
Please describe alternative solutions or features you have considered.
Doing so would likely limit how much tweaking a user could do for each of the classes involved (processor, ensemble, kernel, etc) but for those cases one can just fall back to the lengthier more verbose construction of each class individually.

@lbluque lbluque added the enhancement New feature or request label Sep 2, 2021
@lbluque
Copy link
Collaborator Author

lbluque commented Dec 8, 2022

I'm not sure how much easier this makes using the code.....

labeling as wontfix for now. In case anyone actually wants it, feel free to bump this.

@lbluque lbluque added the wontfix This will not be worked on label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant