Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.yml workflow codacy report issue #56

Open
qchempku2017 opened this issue Sep 23, 2023 · 1 comment
Open

test.yml workflow codacy report issue #56

qchempku2017 opened this issue Sep 23, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@qchempku2017
Copy link
Collaborator

Expected Behavior

codacy report should work with any matrix.python_version == any python version without specific condition

Current Behavior

Currently, codacy report can only work with python 3.9 without other condition.
If python 3.11 is used, must add condition: matrix.python_version == '3.11' && github.repository == github.event.pull_request.head.repo.full_name
alongside matrix version check.

Possible Solution

Possibly requires a future update of codacy-coverage-reporter or the github testing environment.

Steps to Reproduce

Context

Detailed Description

Possible Implementation

@qchempku2017 qchempku2017 added the bug Something isn't working label Sep 23, 2023
@qchempku2017 qchempku2017 self-assigned this Sep 23, 2023
@qchempku2017
Copy link
Collaborator Author

This seemingly can be resolved by writing the condition as ${{ matrix.python_version == 3.11 && github.event_name == 'push'}} instead of ${{ matrix.python_version == 3.11}}.

I have not figured out why that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant