Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the rules for a video to be featured #231

Open
Betree opened this issue Jun 27, 2023 · 2 comments · May be fixed by CaptainFact/captain-fact-api#421
Open

Review the rules for a video to be featured #231

Betree opened this issue Jun 27, 2023 · 2 comments · May be fixed by CaptainFact/captain-fact-api#421
Assignees
@Betree
Labels
backend Everything for https://github.com/CaptainFact/captain-fact-api complexity > simple Simple tasks (usually a few hours) improvement Improvements to existing features (enhancements)

Comments

@Betree
Copy link
Member

Betree commented Jun 27, 2023

In https://github.com/CaptainFact/captain-fact-api/blob/a2007b882825ab7053edf6cb2b182fdd733415d8/apps/db/lib/db_schema/video.ex#L291, we've defined very permissive rules for a video to be featured:

  • Posted by a partner
  • OR the video is less than 3 days old
  • OR there are at least 3 citations
@Betree Betree added improvement Improvements to existing features (enhancements) backend Everything for https://github.com/CaptainFact/captain-fact-api labels Jun 27, 2023
@Betree
Copy link
Member Author

Betree commented Jun 27, 2023

@BasileAsti suggested:

On pourrait enlever la condition partenaire
et augmenter la regle citations

From Mathieu:

au lieu du "au moins 3 citations" on pourrait aussi regarder la proportion du nombre de commentaires par rapport au nombre de citations 🤔

@Betree Betree added the complexity > simple Simple tasks (usually a few hours) label Jun 27, 2023
@Miragide
Copy link
Contributor

Miragide commented Jul 3, 2023

Il est proposé par le conseil d'administration de retirer la condition "Postée par un partenaire".

@Betree Betree self-assigned this Sep 2, 2023
@Betree Betree linked a pull request Sep 2, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Betree Betree

Labels
backend Everything for https://github.com/CaptainFact/captain-fact-api complexity > simple Simple tasks (usually a few hours) improvement Improvements to existing features (enhancements)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change rules for Video to be featured CaptainFact/captain-fact-api
2 participants
@Betree @Miragide