You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This discussion is based on an issue originally raised in 2019, which was subsequently moved to #61 (now closed). The original discussion has several comments by @speth.
There appear to be two distinct approaches to simulate surface kinetics problems.
InterfaceKinetics
Reactor + ReactorSurface object in a reactor network
Time integration is handled by two completely separate functions (advance_coverages vs advance).
It is conceivable to merge the approaches by introducing something along the lines of
There are obviously other scenarios, e.g. edges / triple phase boundaries.
The steps to allow for this would require some changes of ReactorBase-derived classes, but would eliminate redundancies in the long run.
An advantage of this approach would be that only one time integration approach needs to be maintained. Further, any future serialization would use the same framework.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
There appear to be two distinct approaches to simulate surface kinetics problems.
InterfaceKinetics
Reactor
+ReactorSurface
object in a reactor networkadvance_coverages
vsadvance
).It is conceivable to merge the approaches by introducing something along the lines of
Example 1:
diamond_cvd.py
Example 2:
surf_pfr.py
There are obviously other scenarios, e.g. edges / triple phase boundaries.
The steps to allow for this would require some changes of
ReactorBase
-derived classes, but would eliminate redundancies in the long run.An advantage of this approach would be that only one time integration approach needs to be maintained. Further, any future serialization would use the same framework.
Beta Was this translation helpful? Give feedback.
All reactions