Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewing image in broot on kitty using filling too much ram #947

Open
mukul1729 opened this issue Sep 23, 2024 · 9 comments
Open

viewing image in broot on kitty using filling too much ram #947

mukul1729 opened this issue Sep 23, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@mukul1729
Copy link

When i view images in broot on kitty terminal, it consistently adds the images into the ram, it never frees it even if i close broot. I will attach the video for your reference. It doesnt happen with fzf tho.

20240923-193634.mp4
@mukul1729 mukul1729 added the bug Something isn't working label Sep 23, 2024
@Canop
Copy link
Owner

Canop commented Sep 23, 2024

I don't reproduce this.

Can you please launch broot with debug log enabled, view 2 images, then quit, and post the log here ?

Also please post your exact version of Kitty.

@mukul1729
Copy link
Author

kitty 0.36.2
broot.log

@mukul1729
Copy link
Author

once I was casually browsing images in broot and it actually filled whole 8 gigs of ram and swap, and my system crashed

@Canop
Copy link
Owner

Canop commented Sep 23, 2024

once I was casually browsing images in broot and it actually filled whole 8 gigs of ram and swap, and my system crashed

I fully understand it's a major bug. I just don't see ATM anything suspect in your log so I don't have explanation for now. I'll have to search for a way to diagnose what happens on your system. Does it happen if you use another compatible terminal, eg wezterm ?

@mukul1729
Copy link
Author

20240923-205319.mp4

Its happening in wezterm also, can you try it with more than 15-20 high quality wallpapers and see if it reproduces?

@Canop
Copy link
Owner

Canop commented Sep 23, 2024

can you try it with more than 15-20 high quality wallpapers and see if it reproduces?

I'm used to browse directories with thousands of files of several MB. To check it's not a recent bug I just passed over more than a dozen GB of images, with no problem and no decrease in available memory.

Besides such a bug would have been reported before if it was frequent.

@mukul1729
Copy link
Author

Oh okay, thanks for making broot tho i use it regularly. One last thing, may i know which linux distro do you use 😀

@Canop
Copy link
Owner

Canop commented Sep 23, 2024

I'm usually on debian, I'm not a power user

@Canop
Copy link
Owner

Canop commented Oct 22, 2024

@mukul1729 Do you by chance have the /tmp folder mounded in RAM ? If so, the last version 1.44.2 should help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants