Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous text "H4" being appended inappropriately to block content in editor #307

Open
davidearl opened this issue Apr 15, 2021 · 1 comment

Comments

@davidearl
Copy link

Hi,

I have editorskit installed in a website under development (it's a very useful set of additions, thank you).

When I am in the block editor (only, not in the public view of the page), with a custom block added which I have written, the h4 headlines in my block content have the string "H4" added to them.

I've debugged this a bit and it boils down to https://github.com/phpbits/block-options/blob/master/src/styles/editor.scss at around line 83.

		h3.wp-block[data-type="core/heading"]:not(.is-selected)::after {
			content: "H3";
		}

		h4::after {  /*  <<<<============== compare with H3 */
			content: "H4";
		}

		h5.wp-block[data-type="core/heading"]:not(.is-selected)::after {
			content: "H5";
		}

h4 seems to be inconsistent with the other heading levels, in that it is being applied to all h4s in that hierarchy, while the other heading levels are being applied more selectively, and as a result some editorskit annotation is being applied in an incorrect context. Is this deliberate for some reason? It really shouldn't be affecting my block content.

I'm attaching a screenshot from the editor, and the Firefox debugger (it's not just FF, Chrome too).

image
image

@FriendlyWP
Copy link
Contributor

This was addressed in a pull request I submitted a while back (#299) - but it was never added in, I don't think this plugin is being maintained anymore, sadly. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants