You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a distinct lack of argument quoting in the shell scripts, so arguments with spaces or e.g. globbing characters like ? or * break things. Of course, users probably shouldn't use spaces in these arguments, but the programs also preferably shouldn't break...
Repro:
$ mkdir "foo bar"
$ cd "foo bar"
$ echo tqdm > requirements.txt
$ mkdir "bar foo"
$ pip-containerize new --slim --prefix "bar foo" requirements.txt
[ INFO ] Constructing configuration
[ INFO ] Using /tmp/cw-XBIMVU as temporary directory
stat: cannot statx './bar': No such file or directory
stat: cannot statx 'foo/': No such file or directory
chgrp: missing operand after ‘/tmp/cw-XBIMVU’
Try 'chgrp --help' for more information.
[ ERROR ] Set CW_DEBUG_KEEP_FILES env variable to keep build files
Terminated
$
The text was updated successfully, but these errors were encountered:
Very valid point, but probably a wontfix at least for now due to a lack of time. Due to the poor craftsmanship of the original code 😅 , there are a bunch of construct like var=($( which cant be fixed automatically and needs manual intervention.
But I'll leave this open for now in case I get around to it.
No worries. For my experiment, I ended up using https://github.com/DeiC-HPC/cotainr/ instead anyway (and contributing a couple of PRs that way too...).
There's a distinct lack of argument quoting in the shell scripts, so arguments with spaces or e.g. globbing characters like
?
or*
break things. Of course, users probably shouldn't use spaces in these arguments, but the programs also preferably shouldn't break...Repro:
The text was updated successfully, but these errors were encountered: