Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories with spaces break things #24

Open
akx opened this issue Jul 24, 2024 · 2 comments
Open

Directories with spaces break things #24

akx opened this issue Jul 24, 2024 · 2 comments
Labels
wontfix This will not be worked on

Comments

@akx
Copy link
Contributor

akx commented Jul 24, 2024

There's a distinct lack of argument quoting in the shell scripts, so arguments with spaces or e.g. globbing characters like ? or * break things. Of course, users probably shouldn't use spaces in these arguments, but the programs also preferably shouldn't break...

Repro:

$ mkdir "foo bar"
$ cd "foo bar"
$ echo tqdm > requirements.txt
$ mkdir "bar foo"
$ pip-containerize new --slim --prefix "bar foo" requirements.txt
[ INFO ] Constructing configuration
[ INFO ] Using /tmp/cw-XBIMVU as temporary directory
stat: cannot statx './bar': No such file or directory
stat: cannot statx 'foo/': No such file or directory
chgrp: missing operand after ‘/tmp/cw-XBIMVU’
Try 'chgrp --help' for more information.
[ ERROR ] Set CW_DEBUG_KEEP_FILES env variable to keep build files
Terminated
$
@Nortamo
Copy link
Collaborator

Nortamo commented Jul 25, 2024

Very valid point, but probably a wontfix at least for now due to a lack of time. Due to the poor craftsmanship of the original code 😅 , there are a bunch of construct like var=($( which cant be fixed automatically and needs manual intervention.
But I'll leave this open for now in case I get around to it.

@akx
Copy link
Contributor Author

akx commented Jul 25, 2024

No worries. For my experiment, I ended up using https://github.com/DeiC-HPC/cotainr/ instead anyway (and contributing a couple of PRs that way too...).

@Nortamo Nortamo added the wontfix This will not be worked on label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants