Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codedoc update plugins doesn't work #62

Open
TysonMN opened this issue Aug 6, 2020 · 8 comments
Open

codedoc update plugins doesn't work #62

TysonMN opened this issue Aug 6, 2020 · 8 comments
Labels
bug Something isn't working pending on external library this issue is pending on another issue/PR of an external library

Comments

@TysonMN
Copy link
Contributor

TysonMN commented Aug 6, 2020

This is a spin off of CONNECT-platform/coding-blog-plugin#8 (comment)

Quoting CONNECT-platform/coding-blog-plugin#8 (comment)

ok the CLI is updated (0.2.2) and from now on you should be able to update this plugin via:

codedoc update plugins

or

codedoc install @codedoc/coding-blog-plugin

codedoc update plugins doesn't do anything for me but codedoc install @codedoc/coding-blog-plugin does. I can use the later command to update coding-blog-plugin from 0.1.10 to 0.1.11.

@loreanvictor
Copy link
Contributor

I suspect it might be an issue with npm. That is the case if cd .codedoc && npm update also has no effect while cd .codedoc && npm install @codedoc/coding-blog-plugin works. codedoc update plugins is basically just a shortcut for the latter.

@bender2k14 If you could trace this issue on NPM's side, please link it here as well. As with other issues that are dependent on some external dependency, we should keep this issue open to monitor the state of the external dependency.

@loreanvictor loreanvictor added the bug Something isn't working label Aug 6, 2020
@loreanvictor
Copy link
Contributor

@bender2k14 could you by any chance have checked if cd .codedoc && npm update has the same effect?

@TysonMN
Copy link
Contributor Author

TysonMN commented Aug 13, 2020

I had not, but I just did. (If you ever ask of me like this, then I will highly prioritize it.)

Same effect. They are both a no-op.

twilliams@EDMONDS MINGW64 /c/Code/Blogs/tyson-williams-blog ((51e6d29...))
$ codedoc update plugins

# Updating plugins ...


twilliams@EDMONDS MINGW64 /c/Code/Blogs/tyson-williams-blog ((51e6d29...))
$ cd .codedoc

twilliams@EDMONDS MINGW64 /c/Code/Blogs/tyson-williams-blog/.codedoc ((51e6d29...))
$ npm update

twilliams@EDMONDS MINGW64 /c/Code/Blogs/tyson-williams-blog/.codedoc ((51e6d29...))
$ cd ..

twilliams@EDMONDS MINGW64 /c/Code/Blogs/tyson-williams-blog ((51e6d29...))
$ codedoc install @codedoc/coding-blog-plugin

# Installing plugins ...
npm WARN [email protected] requires a peer of typescript@* but none is installed. You must install peer dependencies yourself.
npm WARN .codedoc No description
npm WARN .codedoc No repository field.
npm WARN .codedoc No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\watchpack-chokidar2\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

+ @codedoc/[email protected]
updated 1 package and audited 599 packages in 3.762s

10 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

@loreanvictor
Copy link
Contributor

loreanvictor commented Aug 13, 2020

If you ever ask of me like this, then I will highly prioritize it.

Wow thanks. Of course I didn't mean to convey any form of urgency or priority for this, specifically as it is a non-breaking issue.

Could you also paste the contents of .codedoc/package.json in the situation where there should be an update but codedoc/npm update doesn't update anything?

@TysonMN
Copy link
Contributor Author

TysonMN commented Aug 13, 2020

Of course I didn't mean to convey any form of urgency or priority for this, specifically as it is a non-breaking issue.

I enjoy helping others, so if I know it is on your mind, then I will make it happen.

Could you also paste the contents of .codedoc/package.json in the situation where there should be an update but codedoc/npm update doesn't update anything?

Yep. Here is the link, but I copy-paste it here for convenience.

{
  "dependencies": {
    "@codedoc/coding-blog-plugin": "^0.1.10",
    "@codedoc/core": "^0.2.10"
  },
  "devDependencies": {
    "source-map-loader": "^1.0.0"
  }
}

I don't mind continuing to test for you. If you wanted to try yourself though, you can checkout my repo at that commit.

@loreanvictor
Copy link
Contributor

ok so this seems like a weird behavior on part of NPM CLI. @bender2k14 could you open an issue on this repository (regarding behavior of npm update in .codedoc folder, since it definitely should update @codedoc/coding-blog-plugin to 0.1.11 in this case)? I could open an issue myself but I can't replicate the behavior on my machine so perhaps there are some other configurations / parameters involved that I wouldn't be able to provide to npm/cli maintainers should they need it.

@loreanvictor loreanvictor added the pending on external library this issue is pending on another issue/PR of an external library label Aug 14, 2020
@TysonMN
Copy link
Contributor Author

TysonMN commented Aug 15, 2020

Done. The issue is npm/cli#1680.

I don't mind creating an issue for an external library. You are a great help to me simply by showing me where to create the issue.

@loreanvictor
Copy link
Contributor

Thanks a lot! As with other issues pending on external libraries, will keep this one open to monitor the progress and also make changes if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending on external library this issue is pending on another issue/PR of an external library
Projects
None yet
Development

No branches or pull requests

2 participants