Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink URLs in error messages displayed in the browser #59

Closed
TysonMN opened this issue Jul 27, 2020 · 8 comments
Closed

Hyperlink URLs in error messages displayed in the browser #59

TysonMN opened this issue Jul 27, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@TysonMN
Copy link
Contributor

TysonMN commented Jul 27, 2020

Quoting #48 (comment)

...should display nice errors on the page when there is an error during build.

An exceedingly beautiful error message. For reference, it looks like this.

2020-07-27_14-23-41_201_chrome

Now that you included it in the browser, I can think of another improvement.

Can the text...

https://prismjs.com/#supported-languages

...be "upgraded" to a hyperlink?

@loreanvictor loreanvictor added the enhancement New feature or request label Jul 27, 2020
@loreanvictor
Copy link
Contributor

yes it can, great idea!

p.s. why aren't you getting colors on these messages? this has nothing to do with your console anymore, the error string is generated within node and then colored on the client using ansi_up. the end result should look like this:

Screen Shot 2020-07-27 at 9 58 08 PM

@TysonMN
Copy link
Contributor Author

TysonMN commented Jul 27, 2020

why aren't you getting colors on these messages?

shakes head...maybe my computer is just color blind 😛

No colors in Edge either.

this has nothing to do with your console anymore, the error string is generated within node and then colored on the client using ansi_up.

I tried to verify that by running the server in the default Windows command prompt. As seen before, I can execute codedoc but I didn't realize until now that I can't build...for what seems to be an issue related to node even though it is in the path.

How do I fix this?

2020-07-27_15-49-23_203_cmd

@loreanvictor
Copy link
Contributor

Thats pretty strange. unfortunately I do not have a windows laptop around to be able to test soon, but the issue seems to be with this line and in turn these lines. Basically, ts-node and ts-node-dev are not installed as global packages (unlike codedoc-cli), but they are just installed as dependencies of codedoc-cli. This means their binaries should be somewhere around <where-codedoc-cli-is>/node_modules/.bin/, and the exec() function is supposed to run given commands (such as ts-node or ts-node-dev) in an environment with a modified PATH variable including that address.

@loreanvictor
Copy link
Contributor

p.s. not deployed yet. planned to be deployed via 0.2.11

@loreanvictor
Copy link
Contributor

deployed (via 0.2.11).

@TysonMN
Copy link
Contributor Author

TysonMN commented Aug 15, 2020

The links work great.

My colors still don't work, and probably because of that, I find the link hard to read and even look at.

2020-08-14_20-48-00_249_chrome

Can you share a screenshot of what it should look like with the correct colors?

@loreanvictor
Copy link
Contributor

No thats not related to the console colors missing (which is still exceedingly baffling). It is a primary color that doesn't work well with the dialog background, I should actually enforce the color of the links on these overlays I suspect for maximizing readability (instead of allowing it to be picked up from the theme).

@loreanvictor
Copy link
Contributor

fixes deployed via 0.2.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants