Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current development branch is non-determinstic #152

Open
robotopia opened this issue Nov 7, 2020 · 1 comment
Open

Current development branch is non-determinstic #152

robotopia opened this issue Nov 7, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@robotopia
Copy link
Contributor

I've been trying to compare the vdif outputs from different branches that I'm working on to the development branch, and I keep noticing that the results are never identical. I finally tried comparing the outputs of two successive, identical runs of make_beam on the development branch, and the results still differed: the program is non-deterministic. Since there are no random elements being deliberately introduced (that I'm aware of), this counts as a bug (and probably quite an important one, too).

@robotopia robotopia added the bug Something isn't working label Nov 7, 2020
@robotopia
Copy link
Contributor Author

robotopia commented Nov 7, 2020

I need someone to verify what I've found out so far (hence why I assigned Nick). Specifically, a few quick tests seem to show that

  1. only the VDIF outputs are non-deterministic; the PSRFITS files are identical,
  2. it makes no difference whether the analytic beam or the FEE beam is used
    I need someone else to verify these. At the moment, it's pointing to a bug in the IPFB.
    Next, I'll be testing out the "determiniticity" of different git versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants