Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The loadingBuilder method overrides the cached image #47

Open
migdev-br opened this issue Feb 25, 2024 · 5 comments
Open

The loadingBuilder method overrides the cached image #47

migdev-br opened this issue Feb 25, 2024 · 5 comments
Labels
question Further information is requested

Comments

@migdev-br
Copy link

Hi team, before caching the loadingBuilder shows a circular progress indicator with fadeIn effect, which is fine, however, if I navigate to another page and get back, the loadingBuilder checks if the image is cached as expected but it shows nothing before loading the image that was already cached resulting in a terrible UX.

I appreciate it if you guys have a look at this.

Thanks a lot!

@CHRISTOPANANJICKAL
Copy link
Owner

Can you post a sample video showing the issue

@CHRISTOPANANJICKAL CHRISTOPANANJICKAL added the question Further information is requested label Feb 29, 2024
@migdev-br
Copy link
Author

Hi, please check below.
https://github.com/migdev-br/cachtest-app
Thanks,

@CHRISTOPANANJICKAL
Copy link
Owner

CHRISTOPANANJICKAL commented Mar 13, 2024

loading.builder.mp4

@migdev-br I could see the loading builder after navigating again to the image page. Can you please clarify the issue which you have mentioned?

@migdev-br
Copy link
Author

The loading indicator and fade-in effect should be visible only when the image is loading/fetching, once cached the image should appear directly.
That should be the expected behavior from my point of view and also as per cached_network_image package.

@CHRISTOPANANJICKAL
Copy link
Owner

I see. But here when the fastCachedImage is called, we need to check and get the image from the cache which will be an asynchronous function. This function may take some time if the cache db big. So there is no way to avoid a loading indicator until the image is retrieved from the DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants