Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boundary point type and boundary elements for Python version #84

Open
shuoli-code opened this issue Jan 16, 2025 · 6 comments
Open

boundary point type and boundary elements for Python version #84

shuoli-code opened this issue Jan 16, 2025 · 6 comments

Comments

@shuoli-code
Copy link

Hi,

I was using OceanMesh in Python language. I can not get the boundary point type and elements on boundary may be deleted. I saw this was updated in Matlab version and was wondering if this was also integrated into Python version.

Thank you.

Regards,
Shaun

@krober10nd
Copy link
Collaborator

Hi, could you elaborate on what you mean by "boundary point type and elements on boundary"? Are you experiencing some problem with the removal of boundary elements when applying the mesh clean algorithm?

@shuoli-code
Copy link
Author

Thanks for the reply.

"boundary point type and elements on boundary", for example, after generating a mesh, I need land boundary point (could be identified as type '1') and ocean point (could be type of '0'). Same for elements at the land-ocean boundary. But I can't obtain these information from python version of Oceanmesh. There are only points and elements in the mesh. I was wondering if we have the function to identify boundary points and elements?

@krober10nd
Copy link
Collaborator

Ah I see. There's functionality to do that but it's somewhat unfinished.

https://github.com/CHLNDDEV/oceanmesh/pull/72/files#diff-d9988dcdee1ecfb66deaa6efa57c407925aa8620879205ef89b527fdd82d1040R118

@krober10nd
Copy link
Collaborator

To just get the boundary edges you'd use

boundary.get_winded_boundary_edges

@shuoli-code
Copy link
Author

Ah I see. There's functionality to do that but it's somewhat unfinished.

https://github.com/CHLNDDEV/oceanmesh/pull/72/files#diff-d9988dcdee1ecfb66deaa6efa57c407925aa8620879205ef89b527fdd82d1040R118

Thanks, I'll try it. Hopefully it could be finished soon.

@krober10nd
Copy link
Collaborator

I can try to help out with that. Please provide an example mesh with bathymetry interpolated, if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants