PMP::isotropic_remeshing() - fix relaxation of constrained vertices
#8604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
reviewed
Nov 12, 2024
Comment on lines
1359
to
1375
| bool is_move_allowed(const vertex_descriptor v, const bool relax_constraints) const | ||
| { | ||
| if (is_constrained(v)) | ||
| return false; | ||
|
|
||
| std::vector<halfedge_descriptor> border_halfedges; | ||
| for (halfedge_descriptor h : halfedges_around_target(v, mesh_)) | ||
| { | ||
| if (is_on_patch(h)) | ||
| continue; | ||
| else if (is_on_patch_border(h) && relax_constraints) | ||
| continue; | ||
| else | ||
| return false; | ||
| } | ||
| return true; | ||
| } |
There was a problem hiding this comment.
border_halfedges, line 1364, does not seem to be used.
|
I wonder if your changes could be responsible for the runtime error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Constrained vertices, and constrained edges were not properly protected during the smoothing step.
Release Management