Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing methods ignore_all_XXX in graphics scene options #8587

Merged

Conversation

gdamiand
Copy link
Member

@gdamiand gdamiand commented Nov 4, 2024

Summary of Changes

Add the 4 methods ignore_all_XXX in graphics scene options (methods that are documented)
thanks @efifogel

Release Management

  • Affected package(s): Basic_viewer

@sloriot
Copy link
Member

sloriot commented Nov 4, 2024

Should go in 6.0.2, right?

@sloriot
Copy link
Member

sloriot commented Nov 8, 2024

Successfully tested in CGAL 6.1-Ic-14

@sloriot sloriot force-pushed the Basic_viewer-missing-fct_gdamiand branch from 5ad8b69 to 7cd3a8e Compare November 8, 2024 14:57
@github-actions github-actions bot removed the Tested label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot added Tested and removed TODO labels Nov 8, 2024
@sloriot sloriot changed the base branch from master to 6.0.x-branch November 8, 2024 14:58
@sloriot sloriot merged commit 79ac9d9 into CGAL:6.0.x-branch Nov 8, 2024
9 checks passed
@sloriot sloriot deleted the Basic_viewer-missing-fct_gdamiand branch November 8, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants