Triangulation_2: Do not include kernel header #8527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I write an example that is not including EPICK.h and that I use |
|
You should simply remove the default parameter (or hide it behind some macros if you want to be "backward" compatible) |
sloriot
added
the
Not yet approved
sloriot
reviewed
Nov 6, 2024
Triangulation_2/include/CGAL/Constrained_triangulation_plus_2.h
Outdated
Show resolved
Hide resolved
sloriot
added
Cleaning
Under Testing
Tested
and removed
Not yet approved
|
Successfully tested in CGAL 6.1-Ic-15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Do not include
Exact_predicates_inexact_constructions_kernel.handSimple_cartesian.h.Change order of
#includestatements so that the T2 files come first.Forward declare
EpickinConstrained_triangulation_plus_2where it is used for defining aDefaultfor the template parameter (which is not documented).Release Management