Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling mistakes found checking en-GB to en-US #8515

Closed
albert-github opened this issue Oct 3, 2024 · 6 comments
Closed

Spelling mistakes found checking en-GB to en-US #8515

albert-github opened this issue Oct 3, 2024 · 6 comments

Comments

@albert-github
Copy link
Contributor

Based an #8514 a check words that are misspelling in en-US but are correct in en-GB (CGAL normally uses en-US)

Recognized by my spelling checker and by google translate as misspelled

  • analyse ==> analyze
  • analysed ==> analyzed
  • analysing ==> analyzing
  • behaviour ==> behavior
  • behaviours ==> behaviors
  • centre ==> center
  • centred ==> centered
  • centres ==> centers
  • characterising ==> characterizing
  • colour ==> color
  • colouring ==> coloring
  • colours ==> colors
  • customisation ==> customization
  • equalise ==> equalize
  • favour ==> favor
  • favourable ==> favorable
  • favoured ==> favored
  • flavours ==> flavors
  • fulfils ==> fulfills
  • Generalised ==> Generalized
  • initialisation ==> initialization
  • initialise ==> initialize
  • initialised ==> initialized
  • initialises ==> initializes
  • initialising ==> initializing
  • licence ==> license
  • localisation ==> localization
  • localise ==> localize
  • maximise ==> maximize
  • maximises ==> maximizes
  • millimetres ==> millimeters
  • modelled ==> modeled
  • mould ==> mold
  • Neighbour ==> Neighbor
  • neighbouring ==> neighboring
  • neighbours ==> neighbors
  • normalisation ==> normalization
  • Normalise ==> Normalize
  • optimisation ==> optimization
  • optimisations ==> optimizations
  • optimise ==> optimize
  • optimiser ==> optimizer
  • optimising ==> optimizing
  • parameterised ==> parameterized
  • practise ==> practice
  • prioritised ==> prioritized
  • realise ==> realize
  • recognised ==> recognized
  • Recognising ==> Recognizing
  • Regularised ==> Regularized
  • specialisation ==> specialization
  • specialisations ==> specializations
  • specialised ==> specialized
  • standardise ==> standardize
  • utilisation ==> utilization
  • Visualisation ==> Visualization
  • visualised ==> visualized

Recognized by my spelling checker but not by google translate as misspelled

  • Acknowledgement ==> Acknowledgment
  • analogue ==> analog
  • cancelled ==> canceled
  • Cancelling ==> Canceling
  • grey ==> gray
  • greyed ==> grayed
  • modeller ==> modeler Remark a bit strange as modelled ==> modeled is recognized
  • Modellers ==> Modelers
  • modelling ==> modeling

Questions:

  • Should all those misspellings be corrected (except when in the bib file and the original document also has the "misspelling").
  • should we have 1 PR per package

or

  • 1 PR per unique misspelled word(-type)

0r

  • ...
@afabri
Copy link
Member

afabri commented Oct 3, 2024

Note that we do not want to change if the word is part of a function name, because that would be hassle for users. I was for example wondering about gray, but we do it good here.

@albert-github
Copy link
Contributor Author

No variable, class, namespace, function names etc. I would leave out (and bib files have to be checked against the original title as defined by the author(s))

@afabri
Copy link
Member

afabri commented Oct 3, 2024

So if it is only documentation and comment, then I would say, make it just a single PR for the first category.
Concering mould it seems correct to me. See for example here. I guess the word is just too specific.

@afabri
Copy link
Member

afabri commented Oct 3, 2024

In fact no. Mould is British.

@albert-github
Copy link
Contributor Author

I'll have a look.

I think the cancelled / modeller should also be done as e.g. the word canceled is used (e.g. Linear_cell_complex/demo/Linear_cell_complex/MainWindow.cpp) so this would be more consistent (similar for modeller e.g. Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Arrangement_on_surface_2.txt) the other words I didn't check yet.

albert-github added a commit to albert-github/cgal that referenced this issue Oct 5, 2024
Spelling corrections, `en-GB` -> `en-US`
albert-github added a commit to albert-github/cgal that referenced this issue Oct 5, 2024
albert-github added a commit to albert-github/cgal that referenced this issue Oct 6, 2024
The "bib" part.
(checked as well as possible against google and mostly science direct as well)
@albert-github
Copy link
Contributor Author

albert-github commented Oct 6, 2024

@MaelRL MaelRL added the Cleaning label Oct 8, 2024
sloriot added a commit that referenced this issue Oct 14, 2024
issue #8515 Spelling mistakes found checking `en-GB` to `en-US`
sloriot added a commit that referenced this issue Oct 21, 2024
issue #8515 Spelling mistakes found checking `en-GB` to `en-US`
@MaelRL MaelRL closed this as completed Nov 12, 2024
@MaelRL MaelRL added the Doc label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants