Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STL_extension: Fix Base_with_time_stamp #7807

Merged
merged 1 commit into from
Oct 19, 2023
Merged

STL_extension: Fix Base_with_time_stamp #7807

merged 1 commit into from
Oct 19, 2023

Conversation

afabri
Copy link
Member

@afabri afabri commented Oct 18, 2023

Summary of Changes

Remove the copy constructor of Base_with_time_stamp.
Otherwise we have 'N' in the Triangulation_2 testsuite for CGAL 5.5.

Note that the copy constructor is not in 5.6 and master.
Note that this only concerns VC++.

Release Management

  • Affected package(s): STL_extension
  • License and copyright ownership: unchanged

@afabri afabri added this to the 5.5.4 milestone Oct 18, 2023
@sloriot
Copy link
Member

sloriot commented Oct 18, 2023

@lrineau you should merge it now and we'll check all is fine with the next testsuite.

@sloriot
Copy link
Member

sloriot commented Oct 18, 2023

It is a backport of:

commit 166ff0fdc71e9287a9c77e36e047f21b45fce529
Author: Laurent Rineau <[email protected]>
Date:   Tue Feb 14 13:28:07 2023 +0100

    Try to fix compilation with MSVC++

@lrineau lrineau merged commit cc50a6c into CGAL:5.5.x-branch Oct 19, 2023
7 checks passed
@lrineau lrineau self-assigned this Oct 19, 2023
@lrineau lrineau deleted the STL_extension-remove_copy_constructor-GF branch October 19, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrineau lrineau

Labels
Merged_in_5.5.4 Merged_in_5.5.5 Merged_in_5.6.1 Merged_in_5.6.2 Merged_in_6.0 Pkg::STL_Extension
Projects
None yet
Milestone
5.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@afabri @sloriot @lrineau