Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong \ingroup statements #7804

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Fix wrong \ingroup statements #7804

merged 7 commits into from
Oct 30, 2023

Conversation

afabri
Copy link
Member

@afabri afabri commented Oct 17, 2023

Summary of Changes

Fix serveral labels reported by @albert-github

Fixes issues #7793, #7791, #7790, #7788

@afabri
Copy link
Member Author

afabri commented Oct 17, 2023

@sloriot can you have a look at the problem with the label for the do_intersect label reported in Issue #7789

@albert-github
Copy link
Contributor

@afabri, @sloriot see my comment #7789 (comment)

@afabri
Copy link
Member Author

afabri commented Oct 17, 2023

@afabri, @sloriot see my comment #7789 (comment)

What you suggest is indeed the fix. Thanks.

@afabri afabri added this to the 6.0-beta milestone Oct 17, 2023
@afabri afabri added the Doc bug label Oct 17, 2023
@afabri
Copy link
Member Author

afabri commented Oct 17, 2023

@albert-github can you check again, as I think to have fixed all reported issues, and we won't see it in the testsuite (why not activate it there?)

@albert-github
Copy link
Contributor

albert-github commented Oct 17, 2023

We will see it in an overnight documentation build when this proposed pull request is set to under testing (etc.)

@sloriot I think this is a good candidate to be tested

@sloriot
Copy link
Member

sloriot commented Oct 30, 2023

Successfully tested in 6.0-Ic-93

@lrineau lrineau self-assigned this Oct 30, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 30, 2023
@lrineau lrineau merged commit 7ce782e into CGAL:master Oct 30, 2023
9 checks passed
@lrineau lrineau deleted the CGAL-ingroup-GF branch October 30, 2023 16:16
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment