Incorrect closing HTML comment #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of doxygen are more restrictive (and following the rules) in respect to the end comment of a HTML type of comment, i.e. `<!-- ... -->`, so parts of the paragraphs were missing (Triangulation/index.html and Triangulation/group___pkg_triangulations_ref.html) See also https://www.w3.org/TR/2006/REC-xml11-20060816/#sec-comments
albert-github
added a commit
to albert-github/cgal
that referenced
this pull request
Sep 7, 2023
Remove gray background and get some indentation (Note this proposed pull request needs the proposed pull request CGAL#7700)
afabri
approved these changes
Sep 11, 2023
|
Don't we run an html-checker? |
I don't think a HTML checker would be of any use here as the mentioned code is interpreted by doxygen and doxygen follows, now, the rule about the |
|
Create a proposed pull request for doxygen: doxygen/doxygen#10298 |
|
Successfully tested in CGAL-6.0-Ic-61 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of doxygen are more restrictive (and following the rules) in respect to the end comment of a HTML type of comment, i.e.
<!-- ... -->, so parts of the paragraphs were missing (Triangulation/index.html and Triangulation/group___pkg_triangulations_ref.html)See also https://www.w3.org/TR/2006/REC-xml11-20060816/#sec-comments