Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting unoriented polygon soup to polygon mesh #7655

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Converting unoriented polygon soup to polygon mesh #7655

merged 3 commits into from
Oct 19, 2023

Conversation

soesau
Copy link
Member

@soesau soesau commented Aug 18, 2023

Summary of Changes

Changed the output from unoriented polygon soup to polygon mesh

Release Management

@sloriot
Copy link
Member

sloriot commented Aug 24, 2023 •
edited
Loading

Test failing in CGAL-6.0-Ic-46 (segfault)

For example:

@sloriot sloriot added Tests failing Batch_1 First Batch of PRs under testing and removed Under Testing labels Aug 24, 2023
@soesau
Copy link
Member Author

soesau commented Sep 25, 2023

Can we retest this pr in the testsuite? It failed due to using PMP::orient_polygon_soup, while the orient_polygon_soup test itself also failed in the same test run.

@sloriot sloriot added Under Testing Tested and removed Batch_1 First Batch of PRs under testing Under Testing labels Oct 15, 2023
@sloriot
Copy link
Member

sloriot commented Oct 18, 2023

Successfully tested in CGAL-6.0-Ic-86

Issues mentioned above remain but you are right that it is a problem of the called function on those platforms.

@lrineau lrineau self-assigned this Oct 19, 2023
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Ready to be tested and removed Ready to be tested labels Oct 19, 2023
@lrineau lrineau linked an issue Oct 19, 2023 that may be closed by this pull request
Polygonal Surface Reconstruction (polyfit) : result faces orientation ? #7096
Closed
@lrineau lrineau added this to the 6.0-beta milestone Oct 19, 2023
@lrineau lrineau merged commit d5c8582 into CGAL:master Oct 19, 2023
1 check passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 19, 2023
@sloriot sloriot deleted the Polygonal_surface_reconstruction-Unoriented_soup_to_mesh-GF branch October 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot left review comments

Assignees

@sloriot sloriot

@lrineau lrineau

Labels
Bug Merged_in_6.0 Pkg::Polygonal_surface_reconstruction Tested
Projects
None yet
Milestone
6.0-beta
3 participants
@soesau @sloriot @lrineau