Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document 3rd template parameter of CGAL::Apollonius_graph_vertex_base_2< Gt, StoreHidden > #7579

Closed
stla opened this issue Jul 6, 2023 · 1 comment · Fixed by #7619
Closed

document 3rd template parameter of CGAL::Apollonius_graph_vertex_base_2< Gt, StoreHidden > #7579

stla opened this issue Jul 6, 2023 · 1 comment · Fixed by #7619
Assignees
@afabri
Labels
Feature request Pkg::Apollonius_graph_2
Milestone
5.5.4

Comments

@stla
Copy link

stla commented Jul 6, 2023

Issue Details

The class CGAL::Apollonius_graph_vertex_base_2< Gt, StoreHidden > has a third template parameter which is not documented.

This third template parameter can be CGAL::Triangulation_vertex_base_with_info_2<myinfo, myKernel> which is very useful.
@MaelRL MaelRL self-assigned this Jul 6, 2023
@MaelRL MaelRL assigned afabri and unassigned MaelRL Jul 27, 2023
@afabri afabri mentioned this issue Jul 27, 2023
Merged
@MaelRL MaelRL added this to the 5.5.4 milestone Aug 4, 2023
sloriot added a commit that referenced this issue Aug 14, 2023
@sloriot
Apollonius_graph: Fix return type in the documentation (#7619)
0a11c72 
## Summary of Changes

Fix the return type. Document the third template parameter of
`Apollonius_graph_vertex_base_2`.

## Release Management

* Affected package(s): `Apollonius_graph_2`
* Issue(s) solved (if any): fix #7582 and #7579
* Link to compiled documentation:
[link](https://cgal.github.io/7619/v0/Apollonius_graph_2/classCGAL_1_1Apollonius__graph__2.html#a6e6e1b20ab5018c96e4b0ed2c0f0ee00)
and [here
](https://cgal.github.io/7619/v0/Apollonius_graph_2/classCGAL_1_1Apollonius__graph__vertex__base__2.html#acbabb6d26d4d8938bde5bbd6c6e467eb)for
the vertex base.
* License and copyright ownership:  unchanged
@lrineau lrineau linked a pull request Aug 16, 2023 that will close this issue
Apollonius_graph: Fix return type in the documentation #7619
Merged
@lrineau
Copy link
Member

lrineau commented Aug 16, 2023

Fixed by PR #7619.

@lrineau lrineau closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afabri afabri

Labels
Feature request Pkg::Apollonius_graph_2
Projects
None yet
Milestone
5.5.4
Development

Successfully merging a pull request may close this issue.

Apollonius_graph: Fix return type in the documentation afabri/cgal
4 participants
@afabri @stla @MaelRL @lrineau