Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh_3: create a piecewise-manifold criteria, for polyhedral complexes #1925

Closed
lrineau opened this issue Feb 22, 2017 · 3 comments
Closed

Comments

@lrineau
Copy link
Member

lrineau commented Feb 22, 2017

Even if the 2D surface of the mesh domain is not manifold, it is usually piecewise-manifold, being non-manifold only at the 1D curve segments of the domain. There could be a special piecewise-manifold criterion, that ensures that the only non-manifold edges of the c3t3 should be edges corresponding to the 1D curve segments of the domain.

Cc: @janetournois

@lrineau lrineau added this to the 4.11-beta milestone Feb 22, 2017
@lrineau lrineau self-assigned this Feb 22, 2017
@lrineau
Copy link
Member Author

lrineau commented Jun 1, 2017

Each 1D-curve of the domain could have a property that qualifies the topology of surfaces incident to the curve. For a polyhedral complex, for each edge of the curve, we can compute the number of incident facets of the polyhedra, and store the max of that number on the whole curve.

Note that it can be different from the number of incident patches, because a T-junction, for example, can be between only two patches, or even only one that self-intersects.

Given that knowledge, the manifold criterion could be enforced for edges where the number of incident sheets of surfaces is smaller or equal to 2.

@janetournois
Copy link
Member

The manifold criterion does not try to fix manifoldness where features are protected.
Elsewhere, it seems that PR #7754 does what you want.

@lrineau do you agree that ##7754 fixes this issue?

@lrineau
Copy link
Member Author

lrineau commented Oct 11, 2023

I think this issue can be closed indeed. It was probably already "fixed" long ago. ##7754 is a solution for domains where we cannot protect 1D features easily.

@lrineau lrineau closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants