Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs to respect Discord ratelimits #30

Open
brandonsturgeon opened this issue Nov 30, 2022 · 1 comment
Open

Needs to respect Discord ratelimits #30

brandonsturgeon opened this issue Nov 30, 2022 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@brandonsturgeon
Copy link
Member

brandonsturgeon commented Nov 30, 2022

The sender code should read and respect Discord rate-limit Headers to prevent lost webhooks.

Dev notes

In this file: https://github.com/CFC-Servers/cfc_err_forwarder/blob/main/moon/cfc_err_forwarder/discord_interface.moon
It needs to return a function that queues the error for sending, and then start a queue processor that sends the errors as fast as the response headers allow it.

@brandonsturgeon
Copy link
Member Author

This is handled in the Lua Rewrite. Will decide if the feature has to wait until then, or if it should be backported sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant