Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of stable/1.0 crates #9

Open
Byron opened this issue Sep 15, 2023 · 2 comments
Open

Better handling of stable/1.0 crates #9

Byron opened this issue Sep 15, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Byron
Copy link
Owner

Byron commented Sep 15, 2023

Currently one has two options:

  • use --auto-publish-of-stable-crates to safety-bump stable crates just like unstable ones, causing unnecessary churn downstream
  • not do the above and see the publish fail as the manifest wasn't updated with new/bumped versions of workspace dependencies.

What would be required is the give them a patch-level bump instead, while keeping everything else as is (maybe even by default). That way they could be published as usual and everything should work fine.

@Byron Byron added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Sep 15, 2023
@Byron Byron added the good first issue Good for newcomers label Sep 15, 2023
@brooksmtownsend
Copy link

@Byron could you elaborate a bit here on the issue, is it that by default we attempt to bump 1.0.0 crates to 2.0.0? or 1.1.0 instead of a patch version?

@Byron
Copy link
Owner Author

Byron commented May 1, 2024

gitoxide crates are already suffering from this issue, as auto-publish-of-stable-crates is default-off now, just to avoid surprises, but the result of the operation might be then be somewhat incorrect (i forgot details). So these days, I just enable it and indeed auto-bump stable crates, quite a terrible thing to do.

It's definitely something to fix once gix wants to go 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants