Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifiers to interrupts code #21

Open
lonestr9 opened this issue Mar 15, 2016 · 3 comments
Open

Add modifiers to interrupts code #21

lonestr9 opened this issue Mar 15, 2016 · 3 comments

Comments

@lonestr9
Copy link
Contributor

There are times when i do and don't want the interrupts code to trigger, primarily during boss or epic enemy fights where they cannot be stunned / interrupted.
Here is a sample of the modifiers I have added to the Assassin Hatred / Deception code:

//Interrupts
Spell.Cast("Jolt", ret => Me.CurrentTarget.IsCasting && !Me.CurrentTarget.HasDebuff("Unshakeable")),
Spell.Cast("Electrocute", ret => Me.CurrentTarget.IsCasting && !Me.CurrentTarget.HasDebuff("Boss Immunity")),
Spell.Cast("Low Slash", ret => Me.CurrentTarget.IsCasting && !Me.CurrentTarget.HasDebuff("Boss Immunity")),

I am sure others have modifiers they use as well, but this is a simple way to make sure you are only using these abilities where appropriate. If others are interested in updating this, I will work on putting together a list for each spec if possible.

@alltrueist
Copy link
Contributor

It would probably make the most sense to create a bool that checks for any of those buffs/debuffs (are they buffs or debuffs? Big difference).

Something like

private static bool canInterrupt
{
if Me.CurrentTarget.HasDebuff("Unshakeable")
return false;
if Me.CurrentTarget.HasDebuff("Boss Immunity")
return false;
return true;
}

You could then make the list as long as you want and even include specific spells you don't want to interrupt.

@lonestr9
Copy link
Contributor Author

Yes alltrueist, sorry, these are buffs for the bosses. Although I am not excited about a long list, I will begin the work as I said I would :) Might be a couple days to go through the specs, might be a list to start with out there somewhere.

@alltrueist
Copy link
Contributor

Take your time! You've got the big ones right now. You might want to create two separate bools: canInterrupt and shouldInterrupt. In canInterrupt, you'd check to see if the boss is Unshakeable or has Boss Immunity (and that he's casting); in shouldInterrupt, you'd look for spells that we want to interrupt (heals, raid boss abilities, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants