Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move refresh token interval #50

Open
2 tasks done
BuckyMaler opened this issue Jan 2, 2018 · 0 comments
Open
2 tasks done

Move refresh token interval #50

BuckyMaler opened this issue Jan 2, 2018 · 0 comments

Comments

@BuckyMaler
Copy link
Owner

  • I am on the latest Channels version.
  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

A user's access token is refreshed on an interval in app/components/Home.js. I'm uncertain whether this is an appropriate file for that logic. The dilemma is when that component unmounts, the interval is cleared. This isn't an immediate issue, since nearly the entire app lives within the Home component, but if another page were introduced in the future that depends on the YouTube API, this logic could become problematic. If it's decided that the refresh logic is in the appropriate file, then perhaps only the clearInterval needs removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant