Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Quotes!!! #3

Open
BolajiAyodeji opened this issue Dec 18, 2018 · 10 comments
Open

Add more Quotes!!! #3

BolajiAyodeji opened this issue Dec 18, 2018 · 10 comments
Assignees
@BolajiAyodeji
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@BolajiAyodeji
Copy link
Owner

BolajiAyodeji commented Dec 18, 2018 •
edited
Loading

THIS ISSUE IS ALWAYS OPEN

All quotes are stored in src/quotes.json
Our aim is to hit 1000 quotes before Q1 of 2019.
Once we hit this goal, we would have our own API for inspireNuggets 😁
Help us reach this goal by contributing!
Follow this guide to get started.
@BolajiAyodeji BolajiAyodeji added enhancement New feature or request help wanted Extra attention is needed labels Dec 18, 2018
@BolajiAyodeji BolajiAyodeji self-assigned this Dec 18, 2018
@BolajiAyodeji
Copy link
Owner Author

@Siphon880gh @Ekwuno @BolajiAyodeji

@Oluwabammydu
Copy link

Hi, I noticed some irregularities on number 67 and 69.

@Oluwabammydu
Copy link

Since I have been using the extension, there are times when I tried using the search bar and the searched word will be deleted and returned nothing until I tried searching again. Am I the only one experiencing this?

@BolajiAyodeji
Copy link
Owner Author

@Oluwabammydu Hello
Please, this Issue is meant for discussions towards increasing the quotes JSON.
Nex time please kindly Open a new Issue for this!
I would respond to this below!

@BolajiAyodeji
Copy link
Owner Author

Hi, I noticed some irregularities on number 67 and 69.

What irregularities please?
Can you open a new Issue with more details of the errors?

@BolajiAyodeji
Copy link
Owner Author

Since I have been using the extension, there are times when I tried using the search bar and the searched word will be deleted and returned nothing until I tried searching again. Am I the only one experiencing this?

@Oluwabammydu Well, this is strange as I have not experienced this, but I do know that most times Chrome replaces your search text with the extension's URL but it would still run your search.
This effect is from the browser and not the extension
Or can you tell us more details to this?

@BolajiAyodeji BolajiAyodeji added good first issue Good for newcomers question Further information is requested labels Apr 12, 2019
@allcontributors allcontributors bot mentioned this issue Jul 5, 2019
Merged
Repository owner deleted a comment from allcontributors bot Jul 5, 2019
Repository owner deleted a comment from allcontributors bot Jul 5, 2019
@BolajiAyodeji
Copy link
Owner Author

@all-contributors please add @BolajiAyodeji for code

@allcontributors allcontributors bot mentioned this issue Jul 5, 2019
Merged
@allcontributors
Copy link
Contributor

@BolajiAyodeji

I've put up a pull request to add @BolajiAyodeji! 🎉

@BolajiAyodeji
Copy link
Owner Author

@allcontributors please add @BolajiAyodeji for code

@allcontributors allcontributors bot mentioned this issue Jul 13, 2019
Merged
@allcontributors
Copy link
Contributor

@BolajiAyodeji

I've put up a pull request to add @BolajiAyodeji! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BolajiAyodeji BolajiAyodeji

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BolajiAyodeji @Oluwabammydu