Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction details: Address re-use and payment request display #117

Open
GBKS opened this issue Aug 8, 2024 · 1 comment
Open

Transaction details: Address re-use and payment request display #117

GBKS opened this issue Aug 8, 2024 · 1 comment

Comments

@GBKS
Copy link
Contributor

GBKS commented Aug 8, 2024

Transactions and payment requests can be linked together, and addresses can be used multiple times. If addresses are re-used, this linking may get a bit messy. For example, you received two transactions on an address for which you created one payment request. How can and should the UI display that?

This will likely be an addition to the transaction details screen covered in the activity page in the design docs.

@stackingsaunter
Copy link
Contributor

stackingsaunter commented Sep 18, 2024

So I think there are two scenarios at play now and two ways we can do this:

1. We seperate payment requests from transaction details

  • payment requests display multiple transactions ("activity") to the same address
  • transaction detail pages then just display one transaction

2. We "merge" payment requests with transaction details, when transaction is noticed by mempool.

  • So in that case payment request dissapears in the UI and is effectively a state of transaction before it is noticed by Core. - - We loose viewing payment requests history in that case though I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants